Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ErrSignatureInvalid from jwt-go lib should be handled by jwt parser #947

Open
icamys opened this issue Jan 10, 2020 · 1 comment
Open

ErrSignatureInvalid from jwt-go lib should be handled by jwt parser #947

icamys opened this issue Jan 10, 2020 · 1 comment

Comments

@icamys
Copy link
Contributor

icamys commented Jan 10, 2020

I'm playing around with jwt errors handling and I found out that there is a HS256-specific error in jwt-go library that is returned as inner error by the go-kit parser. I believe that this error should be handled by the parser and ErrTokenInvalid should be returned.

Any thoughts?

@peterbourgon
Copy link
Member

I don't know enough about JWT to make an authoritative judgment. I'd be happy to review a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants