Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do we realy need unsafe in code? #107

Open
Monirzadeh opened this issue Feb 1, 2024 · 3 comments
Open

do we realy need unsafe in code? #107

Monirzadeh opened this issue Feb 1, 2024 · 3 comments

Comments

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Feb 1, 2024

We should try this properly though, unsafe is, well... unsafe. If we see any kind of problem with it we can just remove s2b and properly cast to []byte, but I wonder why they choose to use a memory efficient approach here.

Originally posted by @fmartingr in #96 (comment)

for record #96 (comment)

Copy link

github-actions bot commented Jun 8, 2024

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

Copy link

This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Oct 12, 2024
@Monirzadeh
Copy link
Collaborator Author

no stale

@Monirzadeh Monirzadeh removed the Stale label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant