-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official upload to the Firefox Addon Store #72
Comments
What's the objection for uploading to AMO? |
It is possible to automate this on the CI on release? |
It sure is, and this might be the easiest way to do it: violentmonkey/amo-upload |
I'm just chiming in here to say I was very confused by the out of date Shiori extension on Firefox Addon Store. I thought something was wrong with my Shiori configuration! After seeing this issue I tried to build the extension myself and run it temporarily in my Firefox browser and it worked. Then I had to get an AMO account to sign it myself so I could install it permanently. Only after that did I read the fine print and realize the XPI file was here in the releases. D'oh! A lot of work for nothing :-) But thank you for the extension, and for shiori! |
Anyone knows if is there a process to reclaim the addon UUID? I checked and the current build process is uploading it as unlisted over a new UUID. I just made the migration to manifest v3 and wanted to test out publishing it to the listed channel. |
To quote the moderator dotproto in this recent thread:
Therefore I'm sure that there is no process to reclaim a UUID either, though it would make sense for there to be one - our case being a prime example. That said, we could (as dotproto pointed out) try to contact the author, Nover. Posting a review on the addon's review page would probably work, but since it's not strictly a review, sending him an email might be better. I'm not 100% sure that this is the guy, but given that someone with the same username used to host the Shiori source code on his private git, it adds up. As I am not a contributor to the Shiori repository, I think it would be best if you or someone else more involved with development than me would try and contact him this way. His (hopefully working) email address: [email protected] |
I just sent him an email. Will keep you updated. On the worst case, I just need to reupload the plugin with a different UUID, which is not that big of a deal, but extension users not aware of this conversation won't be able to update. |
Nover quickly answered so I'm happy to announce that the latest shiori extension version is now available in the firefox store: https://addons.mozilla.org/en-US/firefox/addon/shiori_ext/ Thanks Nover for your help with this! |
Wow, that was quick. I'm happy the UUID issue has been resolved. To further prevent user confusion, we should consider getting rid of the other outdated upload, too. I apologize for (again) not contacting the uploader myself, given my limited authority regarding the project. Shiori extension by KZK aka Jordi Coscolla ([email protected]) |
An official upload (via CI/CD?) would make any 3rd party uploads obsolete and also prevent problems like this from happening.
There are two versions available on AMO, both outdated:
I refrained from creating another issue along the lines of 'Current version unavailable to Android users', because the solution is ultimately the same. (XPI sideloading is a hidden feature in Firefox for Android.)
If you have problems logging into the Shiori extension, please see the following comment: #70 (comment)
The text was updated successfully, but these errors were encountered: