Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build from source using go get command, warc processor throw error #279

Closed
venssy opened this issue Oct 17, 2020 · 3 comments
Closed

Comments

@venssy
Copy link

venssy commented Oct 17, 2020

I try to build by running go get -u -v github.com/go-shiori/shiori, then i can't find executable in $GOPATH/bin, and i notice two problem or warning, what should i do?
# github.com/go-shiori/warc/internal/processor
go/src/github.com/go-shiori/warc/internal/processor/css.go:39:23: cannot use input (type io.Reader) as type *parse.Input in argument to css.NewLexer
go/src/github.com/go-shiori/warc/internal/processor/js.go:27:22: cannot use input (type io.Reader) as type *parse.Input in argument to js.NewLexer

I run on debian9, try with go1.12, 1.13 and 1.15, all same output.

@mailinglists35
Copy link

same here. ubuntu 18.04 lts, golang 1.15

@jcm4atx
Copy link

jcm4atx commented Jul 11, 2021

I found a fix, but now have another problem. Although looks like a completely unrelated problem.

In the file go/pkg/mod/github.com/go-shiori/[email protected]/pkg/warc/internal/archiver/processor.go I changed these lines near the top:

"github.com/tdewolff/parse/v2/css"
"github.com/tdewolff/parse/v2/js"

to this

"github.com/tdewolff/parse/css"
"github.com/tdewolff/parse/js"

But now I have an error further into the build.

go/pkg/mod/github.com/go-shiori/[email protected]/internal/core/processing.go:68:17: undefined: readability.IsReadable
go/pkg/mod/github.com/go-shiori/[email protected]/internal/core/processing.go:70:64: cannot use book.URL (type string) as type *url.URL in argument to readability.FromReader

I don't know golang whatsoever and I'm not certain what I changed even makes sense.

@fmartingr
Copy link
Member

It seems that one shiori dependency to package archives is unmaintained. We need to replace it.

Moved to #353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants