feat: support cmds in status

Author: sedyh

executor_test.go

@@ -7,6 +7,8 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"sort"
+	"strings"
 	"testing"
 
 	"github.com/sebdah/goldie/v2"
@@ -15,7 +17,6 @@ import (
 
 	"github.com/go-task/task/v3"
 	"github.com/go-task/task/v3/internal/experiments"
-	"github.com/go-task/task/v3/internal/filepathext"
 	"github.com/go-task/task/v3/taskfile/ast"
 )
 
@@ -417,155 +418,6 @@ func TestDeps(t *testing.T) {
 	)
 }
 
-// TODO: mock fs
-func TestStatus(t *testing.T) {
-	t.Parallel()
-
-	const dir = "testdata/status"
-
-	files := []string{
-		"foo.txt",
-		"bar.txt",
-		"baz.txt",
-	}
-
-	for _, f := range files {
-		path := filepathext.SmartJoin(dir, f)
-		_ = os.Remove(path)
-		if _, err := os.Stat(path); err == nil {
-			t.Errorf("File should not exist: %v", err)
-		}
-	}
-
-	// gen-foo creates foo.txt, and will always fail it's status check.
-	NewExecutorTest(t,
-		WithName("run gen-foo 1 silent"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithSilent(true),
-		),
-		WithTask("gen-foo"),
-	)
-	// gen-foo creates bar.txt, and will pass its status-check the 3. time it
-	// is run. It creates bar.txt, but also lists it as its source. So, the checksum
-	// for the file won't match before after the second run as we the file
-	// only exists after the first run.
-	NewExecutorTest(t,
-		WithName("run gen-bar 1 silent"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithSilent(true),
-		),
-		WithTask("gen-bar"),
-	)
-	// gen-silent-baz is marked as being silent, and should only produce output
-	// if e.Verbose is set to true.
-	NewExecutorTest(t,
-		WithName("run gen-baz silent"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithSilent(true),
-		),
-		WithTask("gen-silent-baz"),
-	)
-
-	for _, f := range files {
-		if _, err := os.Stat(filepathext.SmartJoin(dir, f)); err != nil {
-			t.Errorf("File should exist: %v", err)
-		}
-	}
-
-	// Run gen-bar a second time to produce a checksum file that matches bar.txt
-	NewExecutorTest(t,
-		WithName("run gen-bar 2 silent"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithSilent(true),
-		),
-		WithTask("gen-bar"),
-	)
-	// Run gen-bar a third time, to make sure we've triggered the status check.
-	NewExecutorTest(t,
-		WithName("run gen-bar 3 silent"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithSilent(true),
-		),
-		WithTask("gen-bar"),
-	)
-
-	// Now, let's remove source file, and run the task again to to prepare
-	// for the next test.
-	err := os.Remove(filepathext.SmartJoin(dir, "bar.txt"))
-	require.NoError(t, err)
-	NewExecutorTest(t,
-		WithName("run gen-bar 4 silent"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithSilent(true),
-		),
-		WithTask("gen-bar"),
-	)
-	// all: not up-to-date
-	NewExecutorTest(t,
-		WithName("run gen-foo 2"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-		),
-		WithTask("gen-foo"),
-	)
-	// status: not up-to-date
-	NewExecutorTest(t,
-		WithName("run gen-foo 3"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-		),
-		WithTask("gen-foo"),
-	)
-	// sources: not up-to-date
-	NewExecutorTest(t,
-		WithName("run gen-bar 5"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-		),
-		WithTask("gen-bar"),
-	)
-	// all: up-to-date
-	NewExecutorTest(t,
-		WithName("run gen-bar 6"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-		),
-		WithTask("gen-bar"),
-	)
-	// sources: not up-to-date, no output produced.
-	NewExecutorTest(t,
-		WithName("run gen-baz 2"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-		),
-		WithTask("gen-silent-baz"),
-	)
-	// up-to-date, no output produced
-	NewExecutorTest(t,
-		WithName("run gen-baz 3"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-		),
-		WithTask("gen-silent-baz"),
-	)
-	// up-to-date, output produced due to Verbose mode.
-	NewExecutorTest(t,
-		WithName("run gen-baz 4 verbose"),
-		WithExecutorOptions(
-			task.WithDir(dir),
-			task.WithVerbose(true),
-		),
-		WithTask("gen-silent-baz"),
-		WithPostProcessFn(PPRemoveAbsolutePaths),
-	)
-}
-
 func TestPrecondition(t *testing.T) {
 	t.Parallel()
 	const dir = "testdata/precondition"
@@ -948,3 +800,89 @@ func TestVarInheritance(t *testing.T) {
 		)
 	}
 }
+
+func TestStatusFor(t *testing.T) {
+	t.Parallel()
+
+	statusDir := "testdata/status"
+
+	// Setup test files
+	if err := os.MkdirAll(statusDir, 0755); err != nil {
+		t.Fatalf("Failed to create test directory: %v", err)
+	}
+
+	// Create test files
+	fooPath := filepath.Join(statusDir, "foo.txt")
+	barPath := filepath.Join(statusDir, "bar.txt")
+	statusPath := filepath.Join(statusDir, "status.txt")
+
+	// Clean up before test
+	os.Remove(fooPath)
+	os.Remove(barPath)
+	os.Remove(statusPath)
+
+	// Create test files
+	if err := os.WriteFile(fooPath, []byte("foo content"), 0644); err != nil {
+		t.Fatalf("Failed to create foo.txt: %v", err)
+	}
+	if err := os.WriteFile(barPath, []byte("bar content"), 0644); err != nil {
+		t.Fatalf("Failed to create bar.txt: %v", err)
+	}
+
+	// Defer cleanup
+	defer func() {
+		os.Remove(fooPath)
+		os.Remove(barPath)
+		os.Remove(statusPath)
+	}()
+
+	tests := []struct {
+		name      string
+		wantErr   bool
+		checkFunc func(t *testing.T)
+	}{
+		{
+			name: "status-generates",
+			checkFunc: func(t *testing.T) {
+				// After running status-generates, check that status.txt contains both foo.txt and bar.txt
+				content, err := os.ReadFile(statusPath)
+				require.NoError(t, err)
+				lines := strings.Split(strings.TrimSpace(string(content)), "\n")
+				sort.Strings(lines)
+				assert.Equal(t, []string{"bar.txt", "foo.txt"}, lines)
+			},
+		},
+	}
+
+	for _, test := range tests {
+		test := test // Capture range variable
+		t.Run(test.name, func(t *testing.T) {
+			// Remove status.txt before each test
+			os.Remove(statusPath)
+
+			// Create executor options
+			testOpts := []ExecutorTestOption{
+				WithName(test.name),
+				WithExecutorOptions(
+					task.WithDir(statusDir),
+					task.WithSilent(false), // Set to false to see command output
+					task.WithVerbose(true),
+					task.WithForce(true),
+				),
+				WithTask(test.name),
+				WithStatusError(), // Run Status() to execute status commands
+			}
+			if test.wantErr {
+				testOpts = append(testOpts, WithRunError())
+			}
+
+			// Run the test
+			NewExecutorTest(t, testOpts...)
+
+			// Check results
+			if test.checkFunc != nil {
+				test.checkFunc(t)
+			}
+		})
+	}
+}

internal/fingerprint/status.go

@@ -22,15 +22,15 @@ func NewStatusChecker(logger *logger.Logger) StatusCheckable {
 func (checker *StatusChecker) IsUpToDate(ctx context.Context, t *ast.Task) (bool, error) {
 	for _, s := range t.Status {
 		err := execext.RunCommand(ctx, &execext.RunCommandOptions{
-			Command: s,
+			Command: s.Cmd,
 			Dir:     t.Dir,
 			Env:     env.Get(t),
 		})
 		if err != nil {
-			checker.logger.VerboseOutf(logger.Yellow, "task: status command %s exited non-zero: %s\n", s, err)
+			checker.logger.VerboseOutf(logger.Yellow, "task: status command %s exited non-zero: %s\n", s.Cmd, err)
 			return false, nil
 		}
-		checker.logger.VerboseOutf(logger.Yellow, "task: status command %s exited zero\n", s)
+		checker.logger.VerboseOutf(logger.Yellow, "task: status command %s exited zero\n", s.Cmd)
 	}
 	return true, nil
 }

internal/fingerprint/task_test.go

@@ -72,7 +72,7 @@ func TestIsTaskUpToDate(t *testing.T) {
 		{
 			name: "expect TRUE when status is up-to-date and sources are not defined",
 			task: &ast.Task{
-				Status:  []string{"status"},
+				Status:  []*ast.StatusCmd{{Cmd: "status"}},
 				Sources: nil,
 			},
 			setupMockStatusChecker: func(m *mocks.StatusCheckable) {
@@ -84,7 +84,7 @@ func TestIsTaskUpToDate(t *testing.T) {
 		{
 			name: "expect TRUE when status and sources are up-to-date",
 			task: &ast.Task{
-				Status:  []string{"status"},
+				Status:  []*ast.StatusCmd{{Cmd: "status"}},
 				Sources: []*ast.Glob{{Glob: "sources"}},
 			},
 			setupMockStatusChecker: func(m *mocks.StatusCheckable) {
@@ -98,7 +98,7 @@ func TestIsTaskUpToDate(t *testing.T) {
 		{
 			name: "expect FALSE when status is up-to-date, but sources are NOT up-to-date",
 			task: &ast.Task{
-				Status:  []string{"status"},
+				Status:  []*ast.StatusCmd{{Cmd: "status"}},
 				Sources: []*ast.Glob{{Glob: "sources"}},
 			},
 			setupMockStatusChecker: func(m *mocks.StatusCheckable) {
@@ -112,7 +112,7 @@ func TestIsTaskUpToDate(t *testing.T) {
 		{
 			name: "expect FALSE when status is NOT up-to-date and sources are not defined",
 			task: &ast.Task{
-				Status:  []string{"status"},
+				Status:  []*ast.StatusCmd{{Cmd: "status"}},
 				Sources: nil,
 			},
 			setupMockStatusChecker: func(m *mocks.StatusCheckable) {
@@ -124,7 +124,7 @@ func TestIsTaskUpToDate(t *testing.T) {
 		{
 			name: "expect FALSE when status is NOT up-to-date, but sources are up-to-date",
 			task: &ast.Task{
-				Status:  []string{"status"},
+				Status:  []*ast.StatusCmd{{Cmd: "status"}},
 				Sources: []*ast.Glob{{Glob: "sources"}},
 			},
 			setupMockStatusChecker: func(m *mocks.StatusCheckable) {
@@ -138,7 +138,7 @@ func TestIsTaskUpToDate(t *testing.T) {
 		{
 			name: "expect FALSE when status and sources are NOT up-to-date",
 			task: &ast.Task{
-				Status:  []string{"status"},
+				Status:  []*ast.StatusCmd{{Cmd: "status"}},
 				Sources: []*ast.Glob{{Glob: "sources"}},
 			},
 			setupMockStatusChecker: func(m *mocks.StatusCheckable) {