feat: allow providing single or multi prompts #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmaerten
requested changes
Oct 17, 2024
Member
vmaerten
left a comment
vmaerten
left a comment
There was a problem hiding this comment.
Hello!
Thanks for working on this !! 🔥 I like the feature
I've left some comments!
vmaerten
approved these changes
Oct 18, 2024
Member
vmaerten
left a comment
vmaerten
left a comment
There was a problem hiding this comment.
lgtm!
Thanks.
Waiting for another review before merging :)
vmaerten
changed the title
Contributor
Author
|
Hey guys! Can I help with something to get it reviewed? |
pd93
approved these changes
Oct 29, 2024
Member
pd93
left a comment
pd93
left a comment
There was a problem hiding this comment.
Hey guys! Can I help with something to get it reviewed?
No help needed, all approved but unmerged PRs will get looked at before a release happens. That said, this looks fine to me. Thanks for the contribution!
pd93
added a commit
that referenced
this pull request
Oct 29, 2024
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it closes #1861!
At the issue, we decided to make
promptaccept one or more values. As thego-yamldoes not support this, the solution is described in this issue: go-yaml/yaml#100A new
Prompttype was introduced and it handle its serialization to allow one or more values.