fix(deferred): add EXIT_CODE to deferred tasks #1967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1966
This pull request includes changes to enhance the handling of deferred commands and variables in tasks, as well as updates to the corresponding tests and task configuration files. The most important changes include adding support for variable substitution in deferred commands.
Enhancements to deferred commands:
task.go: Added logic to handle variable substitution for theValueandShfields in deferred tasks. This ensures that variables are correctly replaced with their values before the command is executed.Updates to tests:
task_test.go: Added new test cases to verify that deferred commands with variable substitution are executed correctly, including handling ofEXIT_CODEand other dynamic values.Updates to task configuration:
testdata/deferred/Taskfile.yml: Updated the task configuration to include examples of deferred commands with variable substitution, demonstrating the new functionality and ensuring comprehensive test coverage.