Using `for` with `CLI_ARGS` unexpectedly splits arguments containing spaces

[cjlarose]

Description

mkdir inputs
echo 'hello' > inputs/hello.txt
echo 'world' > inputs/world.txt
echo 'hello world' > inputs/"hello world".txt

$ ls -l inputs 
total 24
-rw-r--r--  1 chrislarose  staff  12 Mar 24 17:22 hello world.txt
-rw-r--r--  1 chrislarose  staff   6 Mar 24 17:22 hello.txt
-rw-r--r--  1 chrislarose  staff   6 Mar 24 17:22 world.txt

Taskfile.yml

# https://taskfile.dev

version: '3'

tasks:
  default:
    cmds:
      - for: { var: CLI_ARGS, as: FILENAME }
        cmd: echo "{{.FILENAME}}"

Then

task default -- inputs/hello.txt inputs/world.txt inputs/"hello world".txt

produces unexpectedly

task: [default] echo "inputs/hello.txt"
inputs/hello.txt
task: [default] echo "inputs/world.txt"
inputs/world.txt
task: [default] echo "'inputs/hello"
'inputs/hello
task: [default] echo "world.txt'"
world.txt'

The command was executed 4 times, even though only 3 arguments were sent to task after --. I personally ran into this when trying to invoke task using xargs

 $ find inputs -type f | xargs task default --
task: [default] echo "inputs/world.txt"
inputs/world.txt
task: [default] echo "inputs/hello"
inputs/hello
task: [default] echo "world.txt"
world.txt
task: [default] echo "inputs/hello.txt"
inputs/hello.txt

Version

Task version: v3.42.1 (h1:HOaFbZGLOrAy2V/dLsX2rGJZVG2Qx6268KUIAIXdNE4=)

Operating system

macOS Sonoma 14.1.2

Experiments Enabled

No response

[cjlarose]

Digging into this a bit, it's clear that even though for: { var: ... } can loop over arrays, CLI_ARGS is not an array of strings, and instead a string containing all of the (possibly quoted) command line arguments after --, delimited by the space character.

In the example above, CLI_ARGS would be the string containing

inputs/hello.txt inputs/world.txt 'inputs/hello world.txt'

The default behavior of for: { var: ... } for string variables is to split on whitespace, resulting in 4 items:

1. inputs/hello.txt
2. inputs/world.txt
3. 'inputs/hello
4. world.txt'

It'd be nice if CLI_ARGS was instead an actual array, or if that would be too dramatic a breaking change, a new CLI_ARGS_ARRAY or something would be great.

[pd93]

@cjlarose Your assessment is exactly right. Unfortunately, the CLI_ARGS variable was added before Task supported variables types other than strings, so all the arguments are combined into a single value. You are able to workaround this today by making a small modification to your Taskfile:

# https://taskfile.dev

version: '3'

tasks:
  default:
    vars:
      FILENAMES:
        ref: "splitArgs .CLI_ARGS"
    cmds:
      - for: { var: FILENAMES, as: FILENAME }
        cmd: echo "{{.FILENAME}}"

We decided against changing CLI_ARGS to an array when variables of any type were added because it would've been a breaking change for many users. However, I think it might be nice to create an experiment for this. This way, we can enable the functionality for those who want it without disrupting everyone else and then migrate to it officially for the next major version.