Skip to content

fix: CLI_ARGS is a string and not an array #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2025
Merged

fix: CLI_ARGS is a string and not an array #2191

merged 2 commits into from
Apr 21, 2025

Conversation

@vmaerten
Copy link
Member

@vmaerten vmaerten commented Apr 21, 2025

CLI_ARGS shoud be a string and not an array
Introduced in #2166

@vmaerten vmaerten linked an issue Apr 21, 2025 that may be closed by this pull request
{{.CLI_ARGS}} is templated as an array instead of string. #2190
Closed
@vmaerten vmaerten marked this pull request as ready for review April 21, 2025 17:58
@vmaerten vmaerten requested review from andreynering and pd93 and removed request for andreynering and pd93 April 21, 2025 17:58
@andreynering
Copy link
Member

andreynering commented Apr 21, 2025

@vmaerten CI is failing

@vmaerten
Copy link
Member Author

vmaerten commented Apr 21, 2025 •
edited
Loading

Yep I went too fast.
Fixed now. I don't know why argument was inverted in the call line 79 but not in the underlying method

EDIT: --init still work in my PR

@vmaerten vmaerten requested review from andreynering and pd93 April 21, 2025 18:03
@andreynering andreynering merged commit 3970610 into main Apr 21, 2025
14 checks passed
@andreynering andreynering deleted the fix/cli-args-as-string branch April 21, 2025 19:31
andreynering added a commit that referenced this pull request Apr 21, 2025
@andreynering
chore: add changelog entry for #2191
0805692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreynering andreynering andreynering approved these changes

@pd93 pd93 Awaiting requested review from pd93

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

{{.CLI_ARGS}} is templated as an array instead of string.

3 participants

@vmaerten @andreynering