Task checksum is always the same value in v3.44.0

[pastelmind]

Description

On v3.44.0, Task fails to detect changes in source files because it computes incorrect checksums. When I examined the task checksum files generated in .task/, they always contained 99aa06d3014798d86001c324468d497f regardless of sources.

The bug has been observed on the Windows (amd64) build of v3.44.0. I also tested the macOS (arm64) build of v3.44.0, and it computes checksums correctly. The Windows (amd64) build of the previous version on Winget (v3.43.2) also works fine.

Version

v3.44.0

Operating system

Windows 11 (amd64)

Experiments Enabled

No response

Example Taskfile

# https://taskfile.dev

version: "3"

tasks:
  default:
    sources:
      - input.txt
    cmds:
      - echo input.txt has changed

A reproduction is also available at https://github.com/pastelmind/go-task-bug-repro

[WesselAtWork]

Want to report on this one.

Stepped through the execution of v3.44.0 (NEW) and v3.43.3 (OLD): The problem is OS slashes.

In OLD we have this as the last commit for internal/execext/exec.go
a60c2ec#diff-5f46f3d98aadb7cc3f97fc67e741520ca3118fc5b2bc4003b1571b666617b8cb

task/internal/execext/exec.go

Lines 93 to 100 in a60c2ec

	func escape(s string) string {
	s = filepath.ToSlash(s)
	s = strings.ReplaceAll(s, " ", `\ `)
	s = strings.ReplaceAll(s, "&", `\&`)
	s = strings.ReplaceAll(s, "(", `\(`)
	s = strings.ReplaceAll(s, ")", `\)`)
	return s
	}

Then in it got removed in
b3c4007

BUT the s = filepath.ToSlash(s) was very important for DOS directories to work.
It converts the \ directory slashes to /

It was never replaced in the ExpandFields

task/internal/execext/exec.go

Lines 134 to 136 in a60c2ec

	func ExpandFields(s string) ([]string, error) {
	s = escape(s)
	p := syntax.NewParser()

so the back slashes are passed to the gosh's expand.Fields which then takes the backslashes as escapes.

task/internal/execext/exec.go

Line 132 in b3c4007

return expand.Fields(cfg, words...)

at the wfields, err := cfg.wordFields(word2.Parts) inside FieldsSeq the backslashes are consumed as literals.

As a quick fix adding s = filepath.ToSlash(s) back makes the checksumming work again.

 func ExpandFields(s string) ([]string, error) { 
 	s = filepath.ToSlash(s)
 	p := syntax.NewParser() 
...

[pd93]

@pastelmind @WesselAtWork The escape(s) function was added back in #2322 to fix a different bug. Is one of you able to check if this is fixed in the latest commit on main? I do not have access to a Windows machine at the moment.

[dangweiwu]

The hash value '99aa06d3014798d86001c324468d497f' is an empty string hash value. I have tested v3.43.2, v3.43.3, and v3.44.0, and I hope this issue can be resolved soon.

[pd93]

@pastelmind @WesselAtWork @dangweiwu This should be fixed in v3.44.1. Closing unless someone tells me otherwise.

[WesselAtWork]

Can confirm, it's working (at least for me)

[pastelmind]

@pd93 Sorry for the late reply. I just confirmed that v3.44.1 detects file changes correctly (i.e. computed checksums change when files are modified) on my Windows machine.

BTW, when will v3.44.1 be released for Winget?

[vmaerten]

Hello @pastelmind
I've just submitted the PR to microsoft, It should be available soon
Sorry for the delay