-
Notifications
You must be signed in to change notification settings - Fork 83
Open
Labels
Description
In #975 some code was switched from eagerly-constructed lists to the standard Seq.t
.
However, there's still many places where BatEnum
/Enum
is used, which offers similar lazy-sequence functionality.
We could try switching to the more standard Seq.t
in those Enum
instances, as long as there's no performance regression from doing so.
After #1443 and #1784, only a handful of instances remain:
-
BatFile.lines_of
andBatIO.lines_of
. We'll have to find a sensible way of doing that. -
BatCache
. We only usemanual_cache
which is just a thin wrapper aroundHashtbl
. We could easily just have a version inGoblint_std
. -
BatEnum.uniq
. There is noSeq.uniq
or equivalent. We probably could just avoid that anyway by deduplicating smarter using sets.