Generator::lib_name and with_lib_name should take AsRef<str> instead of AsRef<String>

[ghost]

Neither String or &String actually implement AsRef<String>. To work around that using standard types I had to wrap the string with a smart pointer: .lib_name(Box::new("mylibrary".to_string())).

[karroffel]

Oh that's an oversight, thanks for reporting! 👍 I'll change it right away!

[karroffel]

The type seems to be AsRef<str> which both String, &String and &str should implement, no?

project-utils/src/generate.rs

Lines 71 to 82 in dd8aaa1

	/// Set the name of the crate.
	pub fn with_lib_name(&mut self, name: impl AsRef<str>) {
	let name = name.as_ref().to_string();
	self.lib_name = Some(name);
	}
	/// Set the name of the crate.
	pub fn lib_name(mut self, name: impl AsRef<str>) -> Self {
	self.with_lib_name(name);
	self
	}

[karroffel]

It seems like that's an issue on the latest crates.io version but the git version should work!

[ghost]

Yes, I was using the crates version. I'll switch to the git version for now. Sorry for not checking it first.