Google requiring Google Play Billing Library version 6 or newer #65

flaming-toast · 2024-05-28T17:02:00Z

Hello!

Got this message just today on Google Play Console, it looks like this plugin will need to be upgraded to a newer version of the Google Play Billing library by August 24th if I'm not mistaken?

Veradictus · 2024-05-28T19:29:58Z

+1 needed please

ArcanaCorvus · 2024-05-29T16:06:22Z

We got the same message, hopefully it's a fairly easy fix

dalvaren · 2024-05-29T17:43:52Z

+1 needed

Veradictus · 2024-05-30T04:02:03Z

We got the same message, hopefully it's a fairly easy fix

I think depending on how much the API has changed, I will probably attempt it today to upgrade it and see if it explodes in my face.

Veradictus · 2024-05-30T17:43:11Z

I have no way of testing this at the moment since I am still working on my in-app purchases for my game, is anyone available to check:

https://github.com/Kaetram/godot-google-play-billing

BlitBlatGames · 2024-05-31T10:57:49Z

@Veradictus I successfully built the .aarfile and compiled the app. So, so far so good! I've sent the app to Google for review, will let you know it how it goes once it's approved. Thanks for your the help on this!

BlitBlatGames · 2024-05-31T12:36:51Z

It's been approved by Google, so that's a good sign, but it doesn't seem to be working 100% yet.

It seems the signal sku_details_query_completed is now product_details_query_completed and item.sku is now item.productId

These aren't problems, but what is a problem is that payment.queryProductDetails(["name0", "name1], "inapp") now only returns details for name0 instead of everything in that array.

I'll keep investigating.

BlitBlatGames · 2024-05-31T13:05:33Z

https://github.com/Kaetram/godot-google-play-billing/blob/master/godot-google-play-billing/src/main/java/org/godotengine/godot/plugin/googleplaybilling/GodotGooglePlayBilling.java#L133

That section there needs to be updated to not just get the first product only. This gets all the items in one call:


		ArrayList<QueryProductDetailsParams.Product> productList = new ArrayList<QueryProductDetailsParams.Product>();
		for (String productId : productIdList) {
		    QueryProductDetailsParams.Product product = QueryProductDetailsParams.Product.newBuilder()
                    .setProductId(productId)
                    .setProductType(type)
                    .build();
            productList.add(product);
        }

		QueryProductDetailsParams params = QueryProductDetailsParams.newBuilder()
            .setProductList(productList)
            .build();

I'm not a Java developer (and I really don't like the language, don't @ me!) so there might be a better way of doing this, but so far it seems to be working.

Veradictus · 2024-06-01T05:33:56Z

BlitBlatGames

Solid, will try to fix it. I'm starting in-app purchases for my game today so I will update further as needed, and once the game is published on the Play Store and transactions work as intended, I will create a PR into this repo.

777Pixels · 2024-06-04T00:30:29Z

I think this should fix your last problem...
At least on my side, it fixes some issue I got.
I have taken some code from the godot master branch.

check for the <<<<<<<<<<<<<<<<<<<<<<<<<

	public static Dictionary convertPurchaseToDictionary(Purchase purchase) {
		Dictionary dictionary = new Dictionary();
		dictionary.put("original_json", purchase.getOriginalJson());
		dictionary.put("order_id", purchase.getOrderId());
		dictionary.put("package_name", purchase.getPackageName());
		dictionary.put("purchase_state", purchase.getPurchaseState());
		dictionary.put("purchase_time", purchase.getPurchaseTime());
		dictionary.put("purchase_token", purchase.getPurchaseToken());
		dictionary.put("quantity", purchase.getQuantity());
		dictionary.put("signature", purchase.getSignature());
		// PBL V4 replaced getSku with getSkus to support multi-sku purchases,
		// use the first entry for "sku" and generate an array for "skus"
		// BUG ArrayList<String> skus = purchase.getSkus();    <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("sku", skus.get(0));             <<<<<<<<<<<<<<<<<<<<<<
		// BUG String[] skusArray = skus.toArray(new String[0]); <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("skus", skusArray);
		String[] products = purchase.getProducts().toArray(new String[0]);	// NEW <<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("products", products);					// NEW<<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("is_acknowledged", purchase.isAcknowledged());
		dictionary.put("is_auto_renewing", purchase.isAutoRenewing());
		return dictionary;
	}

Veradictus · 2024-06-04T18:37:33Z

I think this should fix your last problem... At least on my side, it fixes some issue I got. I have taken some code from the godot master branch.

check for the <<<<<<<<<<<<<<<<<<<<<<<<<

	public static Dictionary convertPurchaseToDictionary(Purchase purchase) {
		Dictionary dictionary = new Dictionary();
		dictionary.put("original_json", purchase.getOriginalJson());
		dictionary.put("order_id", purchase.getOrderId());
		dictionary.put("package_name", purchase.getPackageName());
		dictionary.put("purchase_state", purchase.getPurchaseState());
		dictionary.put("purchase_time", purchase.getPurchaseTime());
		dictionary.put("purchase_token", purchase.getPurchaseToken());
		dictionary.put("quantity", purchase.getQuantity());
		dictionary.put("signature", purchase.getSignature());
		// PBL V4 replaced getSku with getSkus to support multi-sku purchases,
		// use the first entry for "sku" and generate an array for "skus"
		// BUG ArrayList<String> skus = purchase.getSkus();    <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("sku", skus.get(0));             <<<<<<<<<<<<<<<<<<<<<<
		// BUG String[] skusArray = skus.toArray(new String[0]); <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("skus", skusArray);
		String[] products = purchase.getProducts().toArray(new String[0]);	// NEW <<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("products", products);					// NEW<<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("is_acknowledged", purchase.isAcknowledged());
		dictionary.put("is_auto_renewing", purchase.isAutoRenewing());
		return dictionary;
	}

Awesome, I haven't had any time to update my code, much appreciated!

777Pixels · 2024-06-04T19:15:24Z

Just found another issue in another file ( GodotGooglePlayBilling.java )
I'm not a java developper, so my code may not be optimal.
But now, I can see my item prices.


@UsedByGodot
	public void queryProductDetails(final String[] list, String type) {
		List<String> productIdList = Arrays.asList(list);

		List<QueryProductDetailsParams.Product> productList = new ArrayList<>();
		for(String productId : productIdList )
		{
			productList.add(  QueryProductDetailsParams.Product.newBuilder()
            					.setProductId(productId)
            					.setProductType(type)
            					.build());
		}
		//QueryProductDetailsParams.Product product = QueryProductDetailsParams.Product.newBuilder()
        //    .setProductId(productIdList.get(0))
        //    .setProductType(type)
        //    .build();

		QueryProductDetailsParams params = QueryProductDetailsParams.newBuilder()
            .setProductList(productList) // Arrays.asList(product))
            .build();

            ...

201949 · 2024-06-05T20:23:49Z

If anyone is interested, here is the repository of the working plugin that I prepared for using Google Play Billing Library version 6.2.1 on Android for Godot 3.5.2
(https://github.com/201949/godot-google-play-billing-6)

flaming-toast · 2024-06-08T09:34:20Z

@201949 You're amazing, thank you so much for this! 🚀 Would you consider making a pull request so that upstream may benefit from it as well? 😊

@akien-mga Hi Rémi! I'm so sorry for the ping, you must have a lot on your plate.. 😭 But I'm not entirely sure who the maintainer of this repository is, and l wanted to at least let someone know about the current situation with this plugin as the Aug 31st deadline will be coming up soon 🙇🏻‍♀️🙇🏻‍♀️ Thank you so much for your attention 🙏

201949 · 2024-06-10T13:37:57Z

@201949 You're amazing, thank you so much for this! 🚀 Would you consider making a pull request so that upstream may benefit from it as well? 😊

@flaming-toast I attempted to transition to Google Play Billing Library version 7 using the existing official upstream plugin, but I was unsuccessful, just as I was with the transition to version 6. Therefore, to address the need for organizing one-time purchases in my existing applications with the outdated library, I created my own solution, guided by official sources on the Google Play Billing Library. Additionally, I have now implemented support for subscriptions and made it publicly available. Here is the Release 6.2.1 with subs

flaming-toast · 2024-06-11T07:44:15Z

@201949 This is awesome! Thank you so much for updating and even improving on the plugin! Since this official repository seems unmaintained now, I'll try migrating to your plugin, will let you know if I run into any issues 🙇🏻‍♀️ Thank you!

dgsdestinygamestudios · 2024-06-11T14:37:00Z

https://github.com/dgsdestinygamestudios/godot-google-play-billing/tree/main
v2 plugin structure, tested on Godot 4.2. Just for android though. If you use, please let me know.

201949 · 2024-06-11T18:17:59Z

https://github.com/dgsdestinygamestudios/godot-google-play-billing/tree/main v2 plugin structure, tested on Godot 4.2. Just for android though. If you use, please let me know.

@dgsdestinygamestudios I'm very happy for you that you managed to build the plugin for the new v2 structure. I hope you will share the source code soon so that we can see your implementation of the methods for working with the Google Play Billing Library. I hope that my solutions have also helped you in your implementation.

dgsdestinygamestudios · 2024-06-12T03:58:29Z

@201949 thank you. Given that Billing library 6 won't be a long-term fix, I figured I should try to go for 7. I've shared java part of the things. If you see anything wrong, feel free to help. Also yes, I've extensively read your code, Remi's code and the documentation to understand what is going on, so thank you.

code-with-max · 2024-06-16T00:14:29Z

I've created an new addon for the Godot 4.2 that integrates with Google Play Billing Library version 7. This module supports all the public functions provided by the library, handles all error codes, and can work with different pricing plans within subscriptions.

You can check it out here: https://github.com/code-with-max/godot-google-play-iapp

I hope this addon helps you with your projects. Feedback and contributions are welcome!

Happy coding!

Krigu · 2024-06-17T08:11:10Z

@code-with-max Do you plan to create a PR and merge it back with the offical plugin?

code-with-max · 2024-06-17T13:31:30Z

@code-with-max Do you plan to create a PR and merge it back with the offical plugin?

I'm not sure I can do this for several reasons:

it's technically impossible, there are too many differences in the code base.
I have already tried to do this before, but the authors prefer to use this one.
Google Play Billing v 5.4.0 not availbe #51 (comment)

Shay-M · 2024-06-20T15:09:17Z

@code-with-max
Thanks for the update, but when I try to use the new version it gives me an error:
Please ensure the app is signed correctly.",
"response_code": 5

(the old version works for me)

And according to a Google search it says:
code 5: BILLING_RESPONSE_RESULT_DEVELOPER_ERROR: Invalid arguments provided to the API. This error can also indicate that the application was not correctly signed or properly set up for In-app Billing in Google Play, or does not have the necessary permissions in its manifest

I see that it gets the product names but when you click on purchase it gives this error.

code-with-max · 2024-06-21T01:46:54Z

@Shay-M
Write an example of your request.

dgsdestinygamestudios · 2024-06-21T10:48:24Z

@code-with-max Thanks for the update, but when I try to use the new version it gives me an error: Please ensure the app is signed correctly.", "response_code": 5

(the old version works for me)

And according to a Google search it says: code 5: BILLING_RESPONSE_RESULT_DEVELOPER_ERROR: Invalid arguments provided to the API. This error can also indicate that the application was not correctly signed or properly set up for In-app Billing in Google Play, or does not have the necessary permissions in its manifest

I see that it gets the product names but when you click on purchase it gives this error.

Check your debug and release keystores.

Project > Export > select Android > scroll down until you see keystores > assign

Shay-M · 2024-06-21T15:34:16Z

Thank you for the quick reply:

@dgsdestinygamestudios
In the old version I only had Release and it worked.
Now I also added it to Debug and it still doesn't work.

@code-with-max
I used the code of the example :

GooglePlayBilling.do_purchase("remove_ads")
func do_purchase(id: String, is_personalized: bool = false): billing.purchase([id], is_personalized)

And of course I changed it:
const ITEM_ACKNOWLEDGED: Array = [ "remove_ads" ]

AndroidIAPP singleton loaded
Billing: start connection
Billing successfully connected
"remove_ads"
"remove_ads"
{
"debug_message": "Please ensure the app is signed correctly.",
"response_code": 5
}

dgsdestinygamestudios · 2024-06-21T16:01:42Z

Thank you for the quick reply:

@dgsdestinygamestudios In the old version I only had Release and it worked. Now I also added it to Debug and it still doesn't work.

@code-with-max I used the code of the example :

GooglePlayBilling.do_purchase("remove_ads") func do_purchase(id: String, is_personalized: bool = false): billing.purchase([id], is_personalized)

And of course I changed it: const ITEM_ACKNOWLEDGED: Array = [ "remove_ads" ]

AndroidIAPP singleton loaded Billing: start connection Billing successfully connected "remove_ads" "remove_ads" { "debug_message": "Please ensure the app is signed correctly.", "response_code": 5 }

Then check your AndroidManifest file and unique name. Make sure you enter the unique name of your game. example: com.example.$genname

Shay-M · 2024-06-21T16:08:44Z

Yes, I have in the settings:

dgsdestinygamestudios · 2024-06-21T16:20:37Z

Did you publish an internal testing with this build? Billing library needs latest aab to work.

Yes, I have in the settings:

code-with-max · 2024-06-21T16:46:25Z

@dgsdestinygamestudios
@Shay-M
I make new versions of plug-in achieve with separated "release" and "debug" versions. In fact, the differences between them are minimal, but I want to eliminate all errors.

https://github.com/code-with-max/godot-google-play-iapp/releases/tag/v1.2

Shay-M · 2024-06-22T14:30:19Z

@dgsdestinygamestudios
@code-with-max
Ok, I will try and update with the new version + through internal testing

In the previous version, I did the run through godot and a physical connection of my device (this is how it worked)

Shay-M · 2024-06-25T16:40:30Z

Nice it works :) But It only works for me only from the google store.
The question is what can be done that will also work in lectures with the physical connection of the device? while debugging

code-with-max · 2024-06-25T17:05:10Z

@Shay-M
I'm sorry, I don't really understand.
Do you want to use this plugin for an application that does not use the Google Store?

Shay-M · 2024-06-25T17:23:05Z

@code-with-max Ah sorry I didn't explain myself.
When I upload the app to the store and run it from there it works.
But when I run it from godot (when I connect the device physically so I can check that everything works - debug locally) it still gives the error response_code": 5

201949 · 2024-06-25T17:43:07Z

As I understand your conversation, you need to register the payment tester in the Google Developer Console. Settings -> License testing. Otherwise, payment testing will have to be carried out in a published application with a real payment method. Or did I misunderstand the conversation?
I will add that essentially, in-app payments can only be tested using the release-signed APK file (the one we upload to the Google Play console).
https://developer.android.com/google/play/billing/test

code-with-max · 2024-06-26T02:46:34Z

@201949 @Shay-M
Don`t forget put license key in special field on Godot export options

Shay-M · 2024-06-27T06:52:28Z

Hi, thank you for your help!
I found a solution to the problem:
"Clear you cache from the google play store account. 😶

https://stackoverflow.com/questions/73025919/google-play-billing-library-5-purchase-flow-fails-but-response-code-indicates-su

I believe that now everything will work

davekaa · 2024-07-27T21:49:38Z

@201949 I'm trying to use your Google Play Billing Library 6.2.1, but when I export my game and test it on device through an internal test, the app crashes after 2 seconds. In your code, the _on_connected() function first starts a 2s timer, so my guess is that whatever happens after crashes the app, I just don't know what.. Have you got any idea? I just copied your code without changes. The app seems to work fine for the first 2 seconds.

EDIT:
I think I just fixed my own issue. I noticed in Google Play Console that the app needed permission for internet. In the Godot export dialog I checked internet and now it seems to work. For if anyone stumbles on the same problem.

davekaa · 2024-07-28T08:31:00Z

@201949 First of all, thank you for making the Google Play Billing 6.2.1 plugin! It was really needed.

Would it be possible to add more documentation/notes it? I'm trying to work with it now but there is a lot of code that I don't know the purpose/workings of. It would be helpful to me and other people who use your code to have some sort of helping hand.

kyoz · 2024-07-29T01:19:43Z

@dalvaren what Godot version are you using? You should give this pr a try. Although it's still not complete but it work for me with basic using. Of course if you're upgrade from a very old version you have to update something.

These signal changed:

		payment.connect("sku_details_query_completed", self, "_on_product_details_query_completed") # SKUs (Dictionary[])
		payment.connect("sku_details_query_error", self, "_on_product_details_query_error") # Response ID (int), Debug message (string), Queried SKUs (string[]

Also replace all .id to .sku

It should work for now.

davekaa · 2024-07-30T09:47:41Z

@kyoz DO you know if that PR also works for Godot 3.5.3?

kyoz · 2024-07-30T09:53:43Z

I'm using it for all of my games now, yes of course that pr is still not completely complete, but if your usecase is simple like me, just allow user to purchase an item, it should work fine.

Here is the build for 3.5.3 which i've built and used:

GodotGooglePlayBilling-v7-3.5.3.zip

You can give it a try.

davekaa · 2024-08-04T10:54:37Z

@201949 Just wanted to let you know that I got everything working thanks to your plugin! Thank you so much for your effort.

I do have 1 question. Does Android/Google have something like a "Restore purchases" feature like in iOS? And if so, does your plugin support that?

EDIT: Asked if I could donate but I found the button in GitHub.

durdenk · 2024-08-11T17:52:55Z

I have projects using at 4.2.1 and 4.3,

How I am going to update to version Google Play Billing Library version 6.0.1 ?

Thanks

AlecAcosta · 2024-08-30T23:28:54Z

Starting tomorrow, our game updates will be rejected unless we update the billing plugin. Do we have any updates on when the plugin will be compatible with the new requirements?

davekaa · 2024-08-31T06:02:49Z

Starting tomorrow, our game updates will be rejected unless we update the billing plugin. Do we have any updates on when the plugin will be compatible with the new requirements?

I used the plugin made by @201949 and solved this problem for my game. Good luck!

wargaming0009 · 2024-09-26T01:16:10Z

Starting tomorrow, our game updates will be rejected unless we update the billing plugin. Do we have any updates on when the plugin will be compatible with the new requirements?

I used the plugin made by @201949 and solved this problem for my game. Good luck!

Hi Is this compatible with godot 4.3?

201949 · 2024-09-26T10:06:23Z

Hi @wargaming0009,

Yes, my plugin also works in Godot 4.3, but at the moment I have not prepared a corresponding release. However, you can rebuild my plugin for the Godot 4.3 library. In this case, you will need to make some changes to your gdscript singleton to match the correct syntax of the new Godot 4.3 version.

If you need a working plugin for the Godot 4.X branch, try using the following plugin:
AndroidIAPP Godot Plugin by @code-with-max

Hope this helps you.

flaming-toast changed the title ~~Google requiring upgrading to Google Play Billing Library version 6 or newer~~ Google requiring Google Play Billing Library version 6 or newer May 28, 2024

This was referenced Jul 22, 2024

Google Play Billing Library: Update from v5.2.1 to v7.0.0 #67

Open

Android Play Billing library version update ? godotengine/godot#94627

Closed

flaming-toast mentioned this issue Nov 13, 2024

Play Billing Library must be updated to at least version 6.0.1 #72

Open

Google requiring Google Play Billing Library version 6 or newer #65

Google requiring Google Play Billing Library version 6 or newer #65

Comments

flaming-toast commented May 28, 2024 • edited Loading

Veradictus commented May 28, 2024

ArcanaCorvus commented May 29, 2024

dalvaren commented May 29, 2024

Veradictus commented May 30, 2024

Veradictus commented May 30, 2024

BlitBlatGames commented May 31, 2024

BlitBlatGames commented May 31, 2024

BlitBlatGames commented May 31, 2024 • edited Loading

Veradictus commented Jun 1, 2024 • edited Loading

777Pixels commented Jun 4, 2024 • edited Loading

Veradictus commented Jun 4, 2024

777Pixels commented Jun 4, 2024

201949 commented Jun 5, 2024

flaming-toast commented Jun 8, 2024

201949 commented Jun 10, 2024

flaming-toast commented Jun 11, 2024

dgsdestinygamestudios commented Jun 11, 2024

201949 commented Jun 11, 2024

dgsdestinygamestudios commented Jun 12, 2024 • edited Loading

code-with-max commented Jun 16, 2024 • edited Loading

Krigu commented Jun 17, 2024

code-with-max commented Jun 17, 2024

Shay-M commented Jun 20, 2024

code-with-max commented Jun 21, 2024 • edited Loading

dgsdestinygamestudios commented Jun 21, 2024

Shay-M commented Jun 21, 2024

dgsdestinygamestudios commented Jun 21, 2024 • edited Loading

Shay-M commented Jun 21, 2024

dgsdestinygamestudios commented Jun 21, 2024

code-with-max commented Jun 21, 2024

Shay-M commented Jun 22, 2024

Shay-M commented Jun 25, 2024

code-with-max commented Jun 25, 2024

Shay-M commented Jun 25, 2024 • edited Loading

201949 commented Jun 25, 2024 • edited Loading

code-with-max commented Jun 26, 2024

Shay-M commented Jun 27, 2024

davekaa commented Jul 27, 2024 • edited Loading

davekaa commented Jul 28, 2024 • edited Loading

kyoz commented Jul 29, 2024

davekaa commented Jul 30, 2024

kyoz commented Jul 30, 2024

davekaa commented Aug 4, 2024 • edited Loading

durdenk commented Aug 11, 2024

AlecAcosta commented Aug 30, 2024

davekaa commented Aug 31, 2024

wargaming0009 commented Sep 26, 2024

201949 commented Sep 26, 2024

flaming-toast commented May 28, 2024 •

edited

Loading

BlitBlatGames commented May 31, 2024 •

edited

Loading

Veradictus commented Jun 1, 2024 •

edited

Loading

777Pixels commented Jun 4, 2024 •

edited

Loading

dgsdestinygamestudios commented Jun 12, 2024 •

edited

Loading

code-with-max commented Jun 16, 2024 •

edited

Loading

code-with-max commented Jun 21, 2024 •

edited

Loading

dgsdestinygamestudios commented Jun 21, 2024 •

edited

Loading

Shay-M commented Jun 25, 2024 •

edited

Loading

201949 commented Jun 25, 2024 •

edited

Loading

davekaa commented Jul 27, 2024 •

edited

Loading

davekaa commented Jul 28, 2024 •

edited

Loading

davekaa commented Aug 4, 2024 •

edited

Loading