Google requiring Google Play Billing Library version 6 or newer

[flaming-toast]

Hello!

Got this message just today on Google Play Console, it looks like this plugin will need to be upgraded to a newer version of the Google Play Billing library by August 24th if I'm not mistaken?

[Veradictus]

+1 needed please

[ArcanaCorvus]

We got the same message, hopefully it's a fairly easy fix

[dalvaren]

+1 needed

[Veradictus]

We got the same message, hopefully it's a fairly easy fix

I think depending on how much the API has changed, I will probably attempt it today to upgrade it and see if it explodes in my face.

[Veradictus]

I have no way of testing this at the moment since I am still working on my in-app purchases for my game, is anyone available to check:

https://github.com/Kaetram/godot-google-play-billing

[BlitBlatGames]

@Veradictus I successfully built the .aarfile and compiled the app. So, so far so good! I've sent the app to Google for review, will let you know it how it goes once it's approved. Thanks for your the help on this!

[BlitBlatGames]

It's been approved by Google, so that's a good sign, but it doesn't seem to be working 100% yet.

It seems the signal sku_details_query_completed is now product_details_query_completed and item.sku is now item.productId

These aren't problems, but what is a problem is that payment.queryProductDetails(["name0", "name1], "inapp") now only returns details for name0 instead of everything in that array.

I'll keep investigating.

[BlitBlatGames]

https://github.com/Kaetram/godot-google-play-billing/blob/master/godot-google-play-billing/src/main/java/org/godotengine/godot/plugin/googleplaybilling/GodotGooglePlayBilling.java#L133

That section there needs to be updated to not just get the first product only. This gets all the items in one call:

		ArrayList<QueryProductDetailsParams.Product> productList = new ArrayList<QueryProductDetailsParams.Product>();
		for (String productId : productIdList) {
		    QueryProductDetailsParams.Product product = QueryProductDetailsParams.Product.newBuilder()
                    .setProductId(productId)
                    .setProductType(type)
                    .build();
            productList.add(product);
        }

		QueryProductDetailsParams params = QueryProductDetailsParams.newBuilder()
            .setProductList(productList)
            .build();

I'm not a Java developer (and I really don't like the language, don't @ me!) so there might be a better way of doing this, but so far it seems to be working.

[Veradictus]

BlitBlatGames

Solid, will try to fix it. I'm starting in-app purchases for my game today so I will update further as needed, and once the game is published on the Play Store and transactions work as intended, I will create a PR into this repo.

[777Pixels]

I think this should fix your last problem...
At least on my side, it fixes some issue I got.
I have taken some code from the godot master branch.

check for the <<<<<<<<<<<<<<<<<<<<<<<<<

	public static Dictionary convertPurchaseToDictionary(Purchase purchase) {
		Dictionary dictionary = new Dictionary();
		dictionary.put("original_json", purchase.getOriginalJson());
		dictionary.put("order_id", purchase.getOrderId());
		dictionary.put("package_name", purchase.getPackageName());
		dictionary.put("purchase_state", purchase.getPurchaseState());
		dictionary.put("purchase_time", purchase.getPurchaseTime());
		dictionary.put("purchase_token", purchase.getPurchaseToken());
		dictionary.put("quantity", purchase.getQuantity());
		dictionary.put("signature", purchase.getSignature());
		// PBL V4 replaced getSku with getSkus to support multi-sku purchases,
		// use the first entry for "sku" and generate an array for "skus"
		// BUG ArrayList<String> skus = purchase.getSkus();    <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("sku", skus.get(0));             <<<<<<<<<<<<<<<<<<<<<<
		// BUG String[] skusArray = skus.toArray(new String[0]); <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("skus", skusArray);
		String[] products = purchase.getProducts().toArray(new String[0]);	// NEW <<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("products", products);					// NEW<<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("is_acknowledged", purchase.isAcknowledged());
		dictionary.put("is_auto_renewing", purchase.isAutoRenewing());
		return dictionary;
	}

[Veradictus]

I think this should fix your last problem... At least on my side, it fixes some issue I got. I have taken some code from the godot master branch.

check for the <<<<<<<<<<<<<<<<<<<<<<<<<

	public static Dictionary convertPurchaseToDictionary(Purchase purchase) {
		Dictionary dictionary = new Dictionary();
		dictionary.put("original_json", purchase.getOriginalJson());
		dictionary.put("order_id", purchase.getOrderId());
		dictionary.put("package_name", purchase.getPackageName());
		dictionary.put("purchase_state", purchase.getPurchaseState());
		dictionary.put("purchase_time", purchase.getPurchaseTime());
		dictionary.put("purchase_token", purchase.getPurchaseToken());
		dictionary.put("quantity", purchase.getQuantity());
		dictionary.put("signature", purchase.getSignature());
		// PBL V4 replaced getSku with getSkus to support multi-sku purchases,
		// use the first entry for "sku" and generate an array for "skus"
		// BUG ArrayList<String> skus = purchase.getSkus();    <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("sku", skus.get(0));             <<<<<<<<<<<<<<<<<<<<<<
		// BUG String[] skusArray = skus.toArray(new String[0]); <<<<<<<<<<<<<<<<<<<<<<
		// BUG dictionary.put("skus", skusArray);
		String[] products = purchase.getProducts().toArray(new String[0]);	// NEW <<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("products", products);					// NEW<<<<<<<<<<<<<<<<<<<<<<
		dictionary.put("is_acknowledged", purchase.isAcknowledged());
		dictionary.put("is_auto_renewing", purchase.isAutoRenewing());
		return dictionary;
	}

Awesome, I haven't had any time to update my code, much appreciated!

[777Pixels]

Just found another issue in another file ( GodotGooglePlayBilling.java )
I'm not a java developper, so my code may not be optimal.
But now, I can see my item prices.

@UsedByGodot
	public void queryProductDetails(final String[] list, String type) {
		List<String> productIdList = Arrays.asList(list);

		List<QueryProductDetailsParams.Product> productList = new ArrayList<>();
		for(String productId : productIdList )
		{
			productList.add(  QueryProductDetailsParams.Product.newBuilder()
            					.setProductId(productId)
            					.setProductType(type)
            					.build());
		}
		//QueryProductDetailsParams.Product product = QueryProductDetailsParams.Product.newBuilder()
        //    .setProductId(productIdList.get(0))
        //    .setProductType(type)
        //    .build();

		QueryProductDetailsParams params = QueryProductDetailsParams.newBuilder()
            .setProductList(productList) // Arrays.asList(product))
            .build();

            ...           

[201949]

If anyone is interested, here is the repository of the working plugin that I prepared for using Google Play Billing Library version 6.2.1 on Android for Godot 3.5.2
(https://github.com/201949/godot-google-play-billing-6)

[flaming-toast]

@201949 You're amazing, thank you so much for this! 🚀 Would you consider making a pull request so that upstream may benefit from it as well? 😊

@akien-mga Hi Rémi! I'm so sorry for the ping, you must have a lot on your plate.. 😭 But I'm not entirely sure who the maintainer of this repository is, and l wanted to at least let someone know about the current situation with this plugin as the Aug 31st deadline will be coming up soon 🙇🏻‍♀️🙇🏻‍♀️ Thank you so much for your attention 🙏