sqlite3: fix errors when Drop()ing a SQLite DB containing internal tables
#1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declaring column as `AUTOINCREMENT` causes SQLite to create a new table `sqlite_sequence` under the hood, which cannot be dropped. This is useful in `migration.Drop()` tests.
hofnarrr
force-pushed
the
hofnarrr/sqlite3/fix-drop-undroppable-tables
branch
from
206e2d0
to
e8788d9
Compare
Running `ANALYZE` causes SQLite to create internal undroppable tables. This is useful during `migrate.Drop()` testing.
In some cases SQLite creates new tables for internal use. The names of these internal schema objects[0] always begin with `sqlite_` and are not to be touched by applications. Example case: if column declaration uses `AUTOINCREMENT` keyword, a new column is created into table `sqlite_sequence` which can not be dropped. Currently, `sqlite3.Drop()` resolves tables to be dropped by querying table `sqlite_master` for all tables in the database. However, this query also returns aforementioned `sqlite_sequence` table. This commit adds a filter to the query resolving tables to be dropped. Filter removes tables starting with `sqlite_` from the query results. [0]: https://www.sqlite.org/fileformat2.html#intschema
hofnarrr
force-pushed
the
hofnarrr/sqlite3/fix-drop-undroppable-tables
branch
from
e8788d9
to
edd80e2
Compare
hofnarrr
changed the title
sqlite3: fix error when Drop()ing a SQLite DB which uses AUTOINCREMENT columnssqlite3: fix errors when Drop()ing a SQLite DB containing internal tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases SQLite creates new tables for internal use. The names of these internal schema objects always begin with
sqlite_and the objects are not to be touched by applications.Example case:
If column declaration uses
AUTOINCREMENTkeyword, a tablesqlite_sequenceis created to track the unique ids. This table can not be dropped.Currently,
sqlite3.Drop()resolves tables to be dropped by querying tablesqlite_masterfor all tables in the database. However, this query also returns aforementionedsqlite_sequencetable leading to errors when trying toDROPit later.This branch adds:
sqlite_from the query results.Fixes #1138