New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL tracing support #1176

Open

NickBelhomme opened this issue Sep 25, 2024 · 1 comment

NickBelhomme commented Sep 25, 2024 •

edited

Loading

Is your feature request related to a problem? Please describe.
We are using pgx/v5: https://github.com/golang-migrate/migrate/tree/master/database/pgx/v5
This works great, however for our general usage we have attached an OTEL tracer to it.
https://pkg.go.dev/github.com/jackc/pgx/v5#ConnConfig.Tracer

    config, _ := pgxpool.ParseConfig("postgres://test:[email protected]:5432/test?sslmode=require&pool_max_conns=10&pool_max_conn_lifetime=20&pool_max_conn_idle_time=10")
    config.Tracer = otelpgx.NewTracer()
   conn, err := pgxpool.NewWithConfig(ctx, config)

currently looking at the migrate codebase I do not see an option to pass the tracer as a config option...

Describe the solution you'd like
A possibility to pass a tracer to the config

Why
It is useful to know how long some migration statements have run atomically .

The text was updated successfully, but these errors were encountered:

Contributor

joschi commented Sep 30, 2024

Kind of related to #1132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment