Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: incorrect link target in http.NewRequestWithContext #70874

Closed
neild opened this issue Dec 16, 2024 · 2 comments
Closed

net/http: incorrect link target in http.NewRequestWithContext #70874

neild opened this issue Dec 16, 2024 · 2 comments
Labels
Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.24

Comments

@neild
Copy link
Contributor

neild commented Dec 16, 2024

http.NewRequestWithContext contains a linkified reference to httptest.NewRequest, but the link target is to the function in the http package.
@gabyhelp gabyhelp mentioned this issue Dec 16, 2024
Closed
@gabyhelp
Copy link

Related Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@yincongcyincong yincongcyincong mentioned this issue Dec 17, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/637035 mentions this issue: net/http: update NewRequestWithContext wrong link to NewRequest

@dr2chase dr2chase added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 23, 2024
@seankhliao seankhliao added the Documentation Issues describing a change to documentation. label Dec 28, 2024
@dmitshur dmitshur added this to the Go1.24 milestone Jan 8, 2025
wyf9661 pushed a commit to wyf9661/go that referenced this issue Jan 21, 2025
@yincongcyincong @wyf9661
net/http: update NewRequestWithContext wrong link to NewRequest
a0fe3d6 
Fixes golang#70874

Change-Id: Icbcfc95e6b45521880287dcc3bc8609461a3b401
GitHub-Last-Rev: 05276c5
GitHub-Pull-Request: golang#70877
Reviewed-on: https://go-review.googlesource.com/c/go/+/637035
Reviewed-by: qiu laidongfeng2 <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: David Chase <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.24
Development

Successfully merging a pull request may close this issue.

net/http: update NewRequestWithContext wrong link to NewRequest yincongcyincong/go
6 participants
@neild @dmitshur @dr2chase @gopherbot @seankhliao @gabyhelp