gopls/release: remove obsolete validateHardCodedVersion

We no longer hard-code the gopls version.

Change-Id: I6f91f6e8f97732803aa5dfe05203ceee0611c489
Reviewed-on: https://go-review.googlesource.com/c/tools/+/562677
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>

Author: findleyr

Diff for: gopls/release/release.go

@@ -14,17 +14,14 @@ package main
 import (
 	"flag"
 	"fmt"
-	"go/types"
 	"log"
 	"os"
 	"os/exec"
 	"path/filepath"
-	"strconv"
 	"strings"
 
 	"golang.org/x/mod/modfile"
 	"golang.org/x/mod/semver"
-	"golang.org/x/tools/go/packages"
 )
 
 var versionFlag = flag.String("version", "", "version to tag")
@@ -52,10 +49,6 @@ func main() {
 	if filepath.Base(wd) != "gopls" {
 		log.Fatalf("must run from the gopls module")
 	}
-	// Confirm that they have updated the hardcoded version.
-	if err := validateHardcodedVersion(*versionFlag); err != nil {
-		log.Fatal(err)
-	}
 	// Confirm that the versions in the go.mod file are correct.
 	if err := validateGoModFile(wd); err != nil {
 		log.Fatal(err)
@@ -64,47 +57,6 @@ func main() {
 	os.Exit(0)
 }
 
-// validateHardcodedVersion reports whether the version hardcoded in the gopls
-// binary is equivalent to the version being published. It reports an error if
-// not.
-func validateHardcodedVersion(version string) error {
-	const debugPkg = "golang.org/x/tools/gopls/internal/debug"
-	pkgs, err := packages.Load(&packages.Config{
-		Mode: packages.NeedName | packages.NeedFiles |
-			packages.NeedCompiledGoFiles | packages.NeedImports |
-			packages.NeedTypes | packages.NeedTypesSizes,
-	}, debugPkg)
-	if err != nil {
-		return err
-	}
-	if len(pkgs) != 1 {
-		return fmt.Errorf("expected 1 package, got %v", len(pkgs))
-	}
-	pkg := pkgs[0]
-	if len(pkg.Errors) > 0 {
-		return fmt.Errorf("failed to load %q: first error: %w", debugPkg, pkg.Errors[0])
-	}
-	obj := pkg.Types.Scope().Lookup("Version")
-	c, ok := obj.(*types.Const)
-	if !ok {
-		return fmt.Errorf("no constant named Version")
-	}
-	hardcodedVersion, err := strconv.Unquote(c.Val().ExactString())
-	if err != nil {
-		return err
-	}
-	if semver.Prerelease(hardcodedVersion) != "" {
-		return fmt.Errorf("unexpected pre-release for hardcoded version: %s", hardcodedVersion)
-	}
-	// Don't worry about pre-release tags and expect that there is no build
-	// suffix.
-	version = strings.TrimSuffix(version, semver.Prerelease(version))
-	if hardcodedVersion != version {
-		return fmt.Errorf("expected version to be %s, got %s", *versionFlag, hardcodedVersion)
-	}
-	return nil
-}
-
 func validateGoModFile(goplsDir string) error {
 	filename := filepath.Join(goplsDir, "go.mod")
 	data, err := os.ReadFile(filename)