Skip to content

rename EventBus.off #140

Open
Open
@shadeofblue

Description

@shadeofblue

I'm finding the name of the EventBus.off very confusing...

I understand that this is thought to be a counterpart to on ... as in on/off ... as an analogy to switch in a mechanism... but this is not such a mechanism... in the context of the event bus, on means: let's schedule _this_ to happen _on_ the occasion of a particular event ... and in this context, off does not mean, disable this event handler but rather remove this event handler ... so the name of the method should reflect that... so, imvho, that should be something like remove or remove_handler or clear or clear_handler ... or something similar...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions