Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Mode leaks #1774

Open
pboguslawski opened this issue May 30, 2022 · 1 comment · May be fixed by #1826
Open

Download Mode leaks #1774

pboguslawski opened this issue May 30, 2022 · 1 comment · May be fixed by #1826
Labels
triage Issues that need to be verified

Comments

@pboguslawski
Copy link

pboguslawski commented May 30, 2022

Problem

One wants to block any requests from Athens proxy to given hostname (say myhost.mydomain) using download mode file as described on

https://gomods.io/configuration/download/

With download mode files

downloadURL = "https://proxy.golang.org"

mode = "sync"

download "myhost.mydomain" {
    mode = "none"
}

Athens blocks (as expected with none) requests for given module version i.e.

http-path=/myhost.mydomain/foo/foo1/@v/v1.0.2.zip

but searching for latest version with

http-path=/myhost.mydomain/foo/@v/list

is not blocked using download mode file like above and Athens tries to dial https://myhost.mydomain/?go-get=1

Shouldn't Athens block such requests without dialing when pattern with none matches hostname?

Athens Version

0.11.0

@ngshiheng
Copy link
Contributor

I see similar behavior on the /@latest endpoint too

@matt0x6F matt0x6F added the triage Issues that need to be verified label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues that need to be verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants