Use a literal sentinel value for kernel init failure #2896
Merged
+1
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_784453957
branch
7 times, most recently
from
5f1b77b to
1241eea
Compare
If a TFLite delegate is compiled into a library then `TfLiteKernelInitFailed` can return a different value than the one that the TFLite interpreter expects. This could be fixed by modifying the linkage of this function but that doesn't seem to be common in TFLite so the easier solution is to use a literal sentinel value (-1) instead of a memory address. PiperOrigin-RevId: 784812328
copybara-service
bot
force-pushed
the
test_784453957
branch
from
1241eea to
faeb8b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a literal sentinel value for kernel init failure
If a TFLite delegate is compiled into a library then
TfLiteKernelInitFailedcan return a different value than the one that the TFLite interpreter expects. This could be fixed by modifying the linkage of this function but that doesn't seem to be common in TFLite so the easier solution is to use a literal sentinel value (-1) instead of a memory address.