Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration should be accepted via a file #89

Open
MJ1998 opened this issue Mar 2, 2024 · 0 comments
Open

Configuration should be accepted via a file #89

MJ1998 opened this issue Mar 2, 2024 · 0 comments

Comments

@MJ1998
Copy link
Collaborator

MJ1998 commented Mar 2, 2024

Similar to this issue on android fhir repo

There are few reasons why someone would want to change configurations while still maintaining the same dataabse:-

library enforced API changes in FhirEngineConfiguration
FhirEngineConfiguration to store 2 configurations: Sync and Database. This will make it more readable.
FhirServices could be refactored to not store iParser, terser, etc which only the DatabaseImpl needs.
application wants to sync to a new server now!
But above or any changes in the FhirEngineConfiguration API will lead to backward incompatibility.

We would need to do versioning to solve for this but a better approach to accept a configuration is via a file so that the file content can change but there is no backward compatibility issue for the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant