Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional models not supported #157

Open
sehoffmann opened this issue May 17, 2024 · 0 comments
Open

Regional models not supported #157

sehoffmann opened this issue May 17, 2024 · 0 comments

Comments

@sehoffmann
Copy link

Currently its not easily possible to evaluate a regional model without duplicating the ERA5 ground truth data set and slicing it accordingly.

The reason for this is the check happening at https://github.com/google-research/weatherbench2/blob/e6b1b9068ffdb9b07d6e315ceaef2de605aa20cc/weatherbench2/evaluation.py#L129C14-L129C34.

This check happens BEFORE(!) slicing the data according to the region config causing regional models to fail (if evaluated against a ground truth data set defined on the whole globe).

Please consider moving this sanity check after _impose_data_selection has been called, i.e. after

forecast_all_times = _impose_data_selection(

This trivial change would make it possible to support regional models without any additional changes if I am not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant