Skip to content

Commit 2687503

Browse files
gonnetxnnpack-bot
authored andcommitted
Remove unused parameter.
PiperOrigin-RevId: 766810743
1 parent 0a3103a commit 2687503

File tree

8 files changed

+16
-20
lines changed

8 files changed

+16
-20
lines changed

src/microkernel-utils.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#include "src/xnnpack/math.h"
1515

1616
static bool fits_in_cache(size_t mr, size_t nc, size_t m_stride,
17-
size_t n_stride, size_t cm_stride, size_t cn_stride,
17+
size_t n_stride, size_t cn_stride,
1818
size_t cache_size, size_t cache_line_size) {
1919
// Check if the bytes fit.
2020
const size_t lines_mr = divide_round_up(mr * m_stride, cache_line_size);
@@ -32,7 +32,7 @@ static bool fits_in_cache(size_t mr, size_t nc, size_t m_stride,
3232

3333
size_t xnn_gemm_best_tile_size(size_t num_groups, size_t m, size_t n,
3434
size_t m_stride, size_t n_stride,
35-
size_t cm_stride, size_t cn_stride, size_t mr,
35+
size_t cn_stride, size_t mr,
3636
size_t nr, size_t num_threads) {
3737
// Adjust `mr` and `nr` if they are larger than `m` and `n`, respectively.
3838
mr = min(mr, m);
@@ -55,11 +55,11 @@ size_t xnn_gemm_best_tile_size(size_t num_groups, size_t m, size_t n,
5555
size_t cache_size = hardware_config->l1_data_cache_bytes;
5656
size_t cache_line_size = hardware_config->l1_data_cache_line_size;
5757
if (XNN_ARCH_X86 || XNN_ARCH_X86_64 ||
58-
(cache_size && !fits_in_cache(mr, nr, m_stride, n_stride, cm_stride,
58+
(cache_size && !fits_in_cache(mr, nr, m_stride, n_stride,
5959
cn_stride, cache_size, cache_line_size))) {
6060
cache_size = hardware_config->l2_data_cache_bytes;
6161
cache_line_size = hardware_config->l2_data_cache_line_size;
62-
if (cache_size && !fits_in_cache(mr, nr, m_stride, n_stride, cm_stride,
62+
if (cache_size && !fits_in_cache(mr, nr, m_stride, n_stride,
6363
cn_stride, cache_size, cache_line_size)) {
6464
// Don't check for cache fit.
6565
cache_size = 0;
@@ -80,7 +80,7 @@ size_t xnn_gemm_best_tile_size(size_t num_groups, size_t m, size_t n,
8080
// If, however, we have more than one tile row, then we want the data used
8181
// to compute a tile of size `mr`x`j*nr` to fit in the cache.
8282
if (mr < m && cache_size &&
83-
!fits_in_cache(mr, j * nr, m_stride, n_stride, cm_stride, cn_stride,
83+
!fits_in_cache(mr, j * nr, m_stride, n_stride, cn_stride,
8484
cache_size, cache_line_size)) {
8585
break;
8686
}

src/operators/batch-matrix-multiply-nc.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -908,9 +908,10 @@ static enum xnn_status reshape_batch_matrix_multiply_nc(
908908
// Compute the optimal tile size for this GEMM.
909909
const size_t nc = xnn_gemm_best_tile_size(
910910
/*num_groups=*/batch_size_c, m, n,
911-
/*m_stride=*/batch_matrix_multiply_op->dynamic_context.gemm->gemm.a_stride,
912-
/*n_stride=*/batch_matrix_multiply_op->dynamic_context.gemm->gemm.w_stride,
913-
/*cm_stride=*/batch_matrix_multiply_op->dynamic_context.gemm->gemm.cm_stride,
911+
/*m_stride=*/
912+
batch_matrix_multiply_op->dynamic_context.gemm->gemm.a_stride,
913+
/*n_stride=*/
914+
batch_matrix_multiply_op->dynamic_context.gemm->gemm.w_stride,
914915
/*cn_stride=*/1 << log2_output_element_size, mr, nr, num_threads);
915916

916917
#if XNN_MAX_UARCH_TYPES > 1

src/operators/convolution-nhwc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2044,7 +2044,6 @@ static enum xnn_status reshape_igemm(
20442044
(input_width * convolution_op->input_pixel_stride
20452045
<< log2_input_element_size),
20462046
/*n_stride=*/convolution_op->dynamic_context.igemm->igemm.w_stride,
2047-
/*cm_stride=*/convolution_op->dynamic_context.igemm->igemm.cm_stride,
20482047
/*cn_stride=*/1 << log2_output_element_size, mr, nr, num_threads);
20492048

20502049
if (dynamic_quantization && convolution_op->convolution_op->zero_size > 0) {

src/operators/deconvolution-nhwc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1340,7 +1340,6 @@ static enum xnn_status reshape_conv_path(
13401340
(input_width * deconvolution_op->input_pixel_stride
13411341
<< log2_input_element_size),
13421342
/*n_stride=*/deconvolution_op->dynamic_context.igemm->igemm.w_stride,
1343-
/*cm_stride=*/deconvolution_op->dynamic_context.igemm->igemm.cm_stride,
13441343
/*cn_stride=*/1 << log2_output_element_size, mr, nr, num_threads);
13451344

13461345
size_t igemm_compute_index = 0;

src/operators/dynamic-fully-connected-nc.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -551,10 +551,10 @@ static enum xnn_status reshape_dynamic_fully_connected_nc(
551551
// Compute the optimal tile size for this GEMM.
552552
const size_t nc = xnn_gemm_best_tile_size(
553553
/*num_groups=*/1, /*m=*/batch_size, /*n=*/output_channels,
554-
/*m_stride=*/dynamic_fully_connected_op->dynamic_context.gemm->gemm.a_stride,
555-
/*n_stride=*/dynamic_fully_connected_op->dynamic_context.gemm->gemm.w_stride,
556-
/*cm_stride=*/
557-
dynamic_fully_connected_op->dynamic_context.gemm->gemm.cm_stride,
554+
/*m_stride=*/
555+
dynamic_fully_connected_op->dynamic_context.gemm->gemm.a_stride,
556+
/*n_stride=*/
557+
dynamic_fully_connected_op->dynamic_context.gemm->gemm.w_stride,
558558
/*cn_stride=*/1 << log2_output_element_size, mr, nr,
559559
/*num_threads=*/pthreadpool_get_threads_count(threadpool));
560560

src/operators/fully-connected-nc.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2467,7 +2467,6 @@ static enum xnn_status reshape_fully_connected_nc(
24672467
/*num_groups=*/1, /*m=*/batch_size, /*n=*/output_channels,
24682468
/*m_stride=*/fully_connected_op->dynamic_context.gemm->gemm.a_stride,
24692469
/*n_stride=*/fully_connected_op->dynamic_context.gemm->gemm.w_stride,
2470-
/*cm_stride=*/fully_connected_op->dynamic_context.gemm->gemm.cm_stride,
24712470
/*cn_stride=*/1 << log2_output_element_size, mr, nr,
24722471
/*num_threads=*/pthreadpool_get_threads_count(threadpool));
24732472

src/xnnpack/microkernel-utils.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@
88

99
#include <stddef.h>
1010

11-
#include "src/xnnpack/common.h"
12-
1311
#ifdef __cplusplus
1412
extern "C" {
1513
#endif
@@ -23,8 +21,8 @@ extern "C" {
2321
// fits in either the L1 or L2 cache.
2422
size_t xnn_gemm_best_tile_size(size_t num_groups, size_t m, size_t n,
2523
size_t m_stride, size_t n_stride,
26-
size_t cm_stride, size_t cn_stride, size_t mr,
27-
size_t nr, size_t num_threads);
24+
size_t cn_stride, size_t mr, size_t nr,
25+
size_t num_threads);
2826

2927
#ifdef __cplusplus
3028
}

test/microkernel-utils.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ TEST(GEMM_BEST_TILE_SIZE, min_tiles_per_thread) {
3434
{(size_t)1, num_threads, 5 * num_threads, 10 * num_threads}) {
3535
const size_t nc = xnn_gemm_best_tile_size(
3636
num_groups, m, n, /*m_stride=*/k * sizeof(float),
37-
/*n_stride=*/k * sizeof(float), /*cm_stride=*/n * sizeof(float),
37+
/*n_stride=*/k * sizeof(float),
3838
/*cn_stride=*/sizeof(float), mr, nr, num_threads);
3939

4040
// Check that `nc` is an integer multiple of `nr` if it is less than `n`.

0 commit comments

Comments
 (0)