Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiments-config.h is hiding the xnnpack.h header #5713

Open
hmaarrfk opened this issue Nov 4, 2023 · 0 comments
Open

experiments-config.h is hiding the xnnpack.h header #5713

hmaarrfk opened this issue Nov 4, 2023 · 0 comments

Comments

@hmaarrfk
Copy link

hmaarrfk commented Nov 4, 2023 •
edited
Loading

The commit
c7e7cde

made experiments-config.h public at the expense of xnnpack.h.

I think there there can only be on public_headers property for each target.

Looking at the file, I think it would be better to add a subdirectory

${CMAKE_INSTALL_INCLUDEDIRS}/xnnpack/experiments-config.h

when the user installs this particular header.

The name doesn't really suggest that it is part of the library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hmaarrfk