Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shader Plugin - support custom uniforms #1830

Open
yiqunw700 opened this issue Dec 2, 2024 · 0 comments · May be fixed by #2015
Open

Shader Plugin - support custom uniforms #1830

yiqunw700 opened this issue Dec 2, 2024 · 0 comments · May be fixed by #2015
Assignees
@yiqunw700
Labels
plugin

Comments

@yiqunw700
Copy link
Contributor

yiqunw700 commented Dec 2, 2024 •
edited
Loading

float, int, color as float3 and float4, other use case for float2, float3 and float4.
@yiqunw700 yiqunw700 moved this to New in DesignCompose Dec 2, 2024
@yiqunw700 yiqunw700 self-assigned this Dec 2, 2024
@yiqunw700 yiqunw700 mentioned this issue Jan 15, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 17, 2025
@yiqunw700
Support shader float/color uniform (#1969)
d956ae0 
Towards: #1830 
Support float and color uniform.

Type set by plugin: float -> float, color -> float3, color with alpha ->
float4
Shader API: 
- float->`setFloatUniform(name, value)`
- color->`setFloatUniform(name, value1, value2, value3)`
- color with alpha -> `setFloatUniform(name, value1, value2, value3,
value4)`

Parse:
shader_schema.rs: `ShaderUniformJson` -> `ShaderUniform`

Customization supports:
- `List<ShaderUniform>`
- `List<State<ShaderUniform>>`

Helper functions to create:
- `float` -> `ShaderUniform`
- `FloatState`->`State<ShaderUniform>`
- `Color`->`ShaderUniform`
- `State<Color>`->`State<ShaderUniform>`
@yiqunw700 yiqunw700 moved this from New to In Progress in DesignCompose Jan 17, 2025
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin
6d82495 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin
a303faa 
Towards: #1830
@yiqunw700 yiqunw700 mentioned this issue Jan 23, 2025
Merged
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin
4e39b88 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin
6feb004 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support shader int uniform
a6df178 
Towards: #1830
@yiqunw700 yiqunw700 mentioned this issue Jan 23, 2025
Merged
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support shader int uniform
3fafb61 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Support shader int uniform
d6c9334 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Make iTime an optional uniform
4fd4825 
Towards: #1830
@yiqunw700 yiqunw700 linked a pull request Jan 23, 2025 that will close this issue
Open
yiqunw700 added a commit that referenced this issue Jan 23, 2025
@yiqunw700
Make iTime an optional uniform
e997602 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin
9b26c73 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin
03bc675 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Support shader int uniform
957ae48 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Support shader int uniform
746337a 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Make iTime an optional uniform
851f577 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Make iTime an optional uniform
97eb7ba 
Towards: #1830
github-merge-queue bot pushed a commit that referenced this issue Jan 24, 2025
@yiqunw700
Support float2, float3 and float4 in shader plugin (#2013)
6bfc119 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Support shader int uniform
ffb75be 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 24, 2025
@yiqunw700
Make iTime an optional uniform
1cb8636 
Towards: #1830
github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2025
@yiqunw700
Support shader int uniform (#2014)
f1efa2a 
Towards: #1830
yiqunw700 added a commit that referenced this issue Jan 25, 2025
@yiqunw700
Make iTime an optional uniform
45cc53e 
Towards: #1830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiqunw700 yiqunw700

Labels
plugin
Projects
DesignCompose
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make iTime an optional uniform google/automotive-design-compose
1 participant
@yiqunw700