-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation Bugs #2000
Comments
rylin8
added a commit
that referenced
this issue
Jan 16, 2025
Fixes #1881. The design switcher has been broken in squoosh due to a number of bugs: #1717 #2000 #2001 #2002 Fixing all of these will take some time. In an effort to make the design switcher functional again, this change makes some small changes in the Figma design by removing some animations and interactions that are buggy. A few small changes in the design switcher code fix the functionality to switch between other documents or branches.
rylin8
added a commit
that referenced
this issue
Jan 16, 2025
Fixes #1881. The design switcher has been broken in squoosh due to a number of bugs: #1717 #2000 #2001 #2002 Fixing all of these will take some time. In an effort to make the design switcher functional again, this change makes some small changes in the Figma design by removing some animations and interactions that are buggy. A few small changes in the design switcher code fix the functionality to switch between other documents or branches.
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 17, 2025
Fixes #1881. The design switcher has been broken in squoosh due to a number of bugs: #1717 #2000 #2001 #2002 Fixing all of these will take some time. In an effort to make the design switcher functional again, this change makes some small changes in the Figma design by removing some animations and interactions that are buggy. A few small changes in the design switcher code fix the functionality to switch between other documents or branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While testing the Interaction test in Validation, under "Variant Tests":
Tap on one of the squares and release quickly. The square ends up in the wrong variant. This may be because the press triggers an animation to another variant, and the release happens before the animation is done. The release interaction doesn't work properly and the node ends up in the pressed-down variant.
If the
transition
inInteractionState.dispatch()
is changed to:val transition = action.node.transitionOrNull
, tapping on the squares sometimes results in a translation animation from a different square.The text was updated successfully, but these errors were encountered: