Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract "common" package do a separate jar #566

Open
oridag opened this issue Jan 28, 2025 · 1 comment
Open

Extract "common" package do a separate jar #566

oridag opened this issue Jan 28, 2025 · 1 comment

Comments

@oridag
Copy link
Contributor

oridag commented Jan 28, 2025

Some of the runtime and compiler dependencies may conflict with other dependencies (in my case antlr and protobuf) so in some cases it is required to wrap the compilation and evaluation API in an external service.
In this case it is helpful to have a minimum-depenedncy module that can be loaded in the client, which have for example the error codes enum, and the code to builds and manipulates ASTs

@l46kok
Copy link
Collaborator

l46kok commented Feb 13, 2025

This has been on my radar for a while, for reasons such as https://jlbp.dev/JLBP-5 (ex: dev.cel.common.CelAbstractSyntaxTree is included in both compiler/runtime jars). But yes, we're eventually aiming to publish //common as its own jar with minimal dependencies and without duplicated classes across. Things like //parser will continue to take a hard dependency on ANTLR, but hopefully a common jar will alleviate the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants