Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Commit 68de51e

Browse files
12wrigjacopybara-github
authored andcommitted
Skip drafting release notes for versions older than the latest release.
RELNOTES: n/a PiperOrigin-RevId: 569297630 Change-Id: Iaa270fbfd2c6acfb0f2e1f34f2efad58561c497b
1 parent 66e2c1f commit 68de51e

File tree

3 files changed

+78
-0
lines changed

3 files changed

+78
-0
lines changed

scripts/release/create_closure_releases.ts

+10
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
* is simply invoked immediately.
2323
*/
2424

25+
import * as semver from 'semver';
26+
2527
import {Change, GitClient} from './git_client';
2628
import {DraftReleaseOptions, GitHubClient} from './github_client';
2729

@@ -247,6 +249,7 @@ export async function createClosureReleases(gitHubApiToken: string) {
247249
// Get the tag of the latest GitHub release.
248250
const from = await github.getLatestReleaseTag();
249251
const versionAtLastRelease = await getMajorVersionAtCommit(git, from);
252+
const lastReleaseSemver = semver.coerce(versionAtLastRelease);
250253

251254
// Get the list of commits since `from`.
252255
const commits = await git.listCommits({from, to: 'HEAD'});
@@ -260,6 +263,13 @@ export async function createClosureReleases(gitHubApiToken: string) {
260263
for (const commit of commits) {
261264
const version = await getMajorVersionAtCommit(git, commit.hash);
262265
seenCommits.push(commit);
266+
if (lastReleaseSemver) {
267+
const semverV = semver.coerce(version);
268+
if (semverV && semver.lt(semverV, lastReleaseSemver)) {
269+
// Skip versions that are older than the last version we released.
270+
continue;
271+
}
272+
}
263273
if (!pJsonVersions.some((entry) => entry.version === version)) {
264274
pJsonVersions.push({
265275
version,

scripts/release/package-lock.json

+65
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scripts/release/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,18 @@
44
"version": "1.0.0",
55
"scripts": {
66
"start": "ts-node create_closure_releases",
7+
"debug": "node --inspect --inspect-brk -r ts-node/register create_closure_releases.ts",
78
"test": "ts-node $(npm bin)/jasmine *_test.ts"
89
},
910
"dependencies": {
1011
"@octokit/rest": "^18.0.6",
12+
"semver": "^7.5.4",
1113
"simple-git": "^3.16.0"
1214
},
1315
"devDependencies": {
1416
"@types/jasmine": "^3.6.0",
1517
"@types/node": "^14.11.2",
18+
"@types/semver": "^7.5.3",
1619
"jasmine": "^3.6.2",
1720
"ts-node": "^10.9.1",
1821
"typescript": "^4.7.4"

0 commit comments

Comments
 (0)