Skip to content
This repository was archived by the owner on Nov 5, 2021. It is now read-only.

Commit 102b313

Browse files
committed
Fix comments and a typo.
PiperOrigin-RevId: 276327600
1 parent c38d6d6 commit 102b313

File tree

3 files changed

+30
-13
lines changed

3 files changed

+30
-13
lines changed

metrics/map.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,9 @@ func (m *Map) String() string {
169169

170170
// ParseMapFromString parses a map value string into a map object.
171171
// Note that the values are always parsed as floats, so even a map with integer
172-
// values will become a float map. For example:
173-
// "map:code 200:10123 404:21" will be parsed as:
172+
// values will become a float map.
173+
// For example:
174+
// "map:code,200:10123,404:21" will be parsed as:
174175
// "map:code 200:10123.000 404:21.000".
175176
func ParseMapFromString(mapValue string) (*Map, error) {
176177
tokens := strings.Split(mapValue, ",")

rds/server/gcp/proto/config.proto

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Configuration proto for GCE targets.
1+
// Configuration proto for GCP provider.
22
// Example config:
33
// {
44
// project: 'test-project-id'
@@ -12,6 +12,14 @@
1212
// name: "lame-duck-targets"
1313
// }
1414
// }
15+
//
16+
// # Pub/Sub messages from the topic lame-duck-targets.
17+
// pubsub_messages {
18+
// subscription {
19+
// name: "lame-duck-targets-{{.hostname}}"
20+
// topic_name: "lame-duck-targets"
21+
// }
22+
// }
1523
// }
1624
syntax = "proto2";
1725

rds/server/kubernetes/proto/config.proto

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,23 @@
1-
// Configuration proto for GCE targets.
2-
// Example config:
3-
// {
4-
// project: 'test-project-id'
1+
// Configuration proto for Kubernetes provider.
52
//
6-
// # GCE instances
7-
// gce_instances {}
3+
// Example provider config:
4+
// {
5+
// pods {}
6+
// }
87
//
9-
// # RTC variables from the config lame-duck-targets, re-evaluated every 10s.
10-
// rtc_variables {
11-
// rtc_config {
12-
// name: "lame-duck-targets"
8+
// In probe config:
9+
// probe {
10+
// targets{
11+
// rds_targets {
12+
// resource_path: "k8s://pods"
13+
// filter {
14+
// key: "namespace"
15+
// value: "default"
16+
// }
17+
// filter {
18+
// key: "name"
19+
// value: "cloudprober.*"
20+
// }
1321
// }
1422
// }
1523
// }

0 commit comments

Comments
 (0)