-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more/custom labels in encodePemBlock
#198
Comments
It's possible to parse with Are these labels documented anywhere, I don't see them in: I could see us allowing a custom string as label too... Maybe as an extra parameter, or as a separate constructor, or just as separate utility methods. Finding a good place to stick in the label is not easy, maybe we shouldn't have used an enum in the first place. On the flip side, if these cases are rare on non-spec'ed, maybe |
For parsing |
Are there any specifications that suggest using a label like It's possible that dumb and simple thing we should do is take a string in the constructor and deprecate the PemLabel enum. Is it common to use labels not specified in RFC 7468. If there is a longer list of common labels, then we can extend the enum. If it's common then we probably need to support string. For the record: a simple workaround is just |
OpenSSL seems to want "EC PRIVATE KEY". The search and replace is what I've been using. It's just a bit ugly. |
For example, in some cases, other parties require "EC PRIVATE KEY" as a label. Which is not one of the options in
PemLabel
.The text was updated successfully, but these errors were encountered: