Skip to content

Commit 5dedc99

Browse files
clean-up logger usage (#937)
1 parent 850fc60 commit 5dedc99

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/MetadataDumper.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,7 @@ private Path prepareOutputPath(
113113
if (matcher.matches()) {
114114
String bucket = matcher.group("bucket");
115115
String path = matcher.group("path");
116-
logger.debug(
117-
String.format(
118-
"Setting up CloudStorageFileSystem with bucket '%s' and path '%s'.", bucket, path));
116+
logger.debug("Setting up CloudStorageFileSystem with bucket '{}' and path '{}'.", bucket, path);
119117
CloudStorageFileSystem cloudStorageFileSystem =
120118
closer.register(CloudStorageFileSystem.forBucket(bucket));
121119
return cloudStorageFileSystem.getPath(path);
@@ -165,7 +163,7 @@ protected boolean run(@Nonnull Connector connector, @Nonnull ConnectorArguments
165163
long outputFileLength = 0;
166164
TaskSetState.Impl state = new TaskSetState.Impl();
167165

168-
logger.info("Using " + connector);
166+
logger.info("Using connector: [{}]", connector);
169167
SummaryPrinter summaryPrinter = new SummaryPrinter();
170168
boolean requiredTaskSucceeded = false;
171169

@@ -183,7 +181,7 @@ protected boolean run(@Nonnull Connector connector, @Nonnull ConnectorArguments
183181
closer.register(FileSystems.newFileSystem(outputUri, fileSystemProperties));
184182
OutputHandleFactory sinkFactory =
185183
new FileSystemOutputHandleFactory(fileSystem, "/"); // It's required to be "/"
186-
logger.debug("Target filesystem is " + sinkFactory);
184+
logger.debug("Target filesystem is [{}]", sinkFactory);
187185

188186
Handle handle = closer.register(connector.open(arguments));
189187

0 commit comments

Comments
 (0)