moved UDF.csv to metadata form query-logs

Author: kaxuna

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeLogsConnector.java

@@ -300,20 +300,6 @@ public final void addTasksTo(
     out.add(new FormatTask(FORMAT_NAME));
     out.add(SnowflakeYamlSummaryTask.create(FORMAT_NAME, arguments));
 
-    if (arguments.isAssessment()) {
-      String userDefinedFunctions =
-          "SELECT FUNCTION_CATALOG, FUNCTION_SCHEMA, FUNCTION_NAME, FUNCTION_LANGUAGE, ARGUMENT_SIGNATURE, "
-              + "FUNCTION_OWNER, COMMENT, VOLATILITY, RUNTIME_VERSION, LAST_ALTERED, "
-              + "PACKAGES, IMPORTS, IS_AGGREGATE, IS_DATA_METRIC, IS_MEMOIZABLE "
-              + "FROM SNOWFLAKE.ACCOUNT_USAGE.FUNCTIONS "
-              + "WHERE FUNCTION_SCHEMA != 'INFORMATION_SCHEMA' "
-              + "AND DELETED IS NULL";
-      out.add(
-          new JdbcSelectTask(
-                  "user_defined_functions.csv", userDefinedFunctions, TaskCategory.OPTIONAL)
-              .withHeaderClass(FunctionsHeader.class));
-    }
-
     // (24 * 7) -> 7 trailing days == 168 hours
     // Actually, on Snowflake, 7 days ago starts at midnight in an unadvertised time zone. What the
     // <deleted>.
@@ -521,24 +507,6 @@ String viewName() {
     }
   }
 
-  private enum FunctionsHeader {
-    FUNCTION_CATALOG,
-    FUNCTION_SCHEMA,
-    FUNCTION_NAME,
-    FUNCTION_LANGUAGE,
-    ARGUMENT_SIGNATURE,
-    FUNCTION_OWNER,
-    COMMENT,
-    VOLATILITY,
-    RUNTIME_VERSION,
-    LAST_ALTERED,
-    PACKAGES,
-    IMPORTS,
-    IS_AGGREGATE,
-    IS_DATA_METRIC,
-    IS_MEMOIZABLE
-  }
-
   @Nonnull
   static String formatPrefix(@Nonnull Class<? extends Enum<?>> enumClass, @Nonnull String view) {
     String selectList =

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakePlanner.java

@@ -30,6 +30,7 @@
 import com.google.edwmigration.dumper.plugin.lib.dumper.spi.SnowflakeMetadataDumpFormat.SchemataFormat;
 import com.google.edwmigration.dumper.plugin.lib.dumper.spi.SnowflakeMetadataDumpFormat.TableStorageMetricsFormat;
 import com.google.edwmigration.dumper.plugin.lib.dumper.spi.SnowflakeMetadataDumpFormat.TablesFormat;
+import com.google.edwmigration.dumper.plugin.lib.dumper.spi.SnowflakeMetadataDumpFormat.UserDefinedFunctionsFormat;
 import com.google.edwmigration.dumper.plugin.lib.dumper.spi.SnowflakeMetadataDumpFormat.WarehousesFormat;
 import javax.annotation.ParametersAreNonnullByDefault;
 
@@ -49,6 +50,7 @@ private enum Format {
     EXTERNAL_TABLES(ExternalTablesFormat.AU_ZIP_ENTRY_NAME),
     FUNCTION_INFO(FunctionInfoFormat.AU_ZIP_ENTRY_NAME),
     TABLE_STORAGE_METRICS(TableStorageMetricsFormat.AU_ZIP_ENTRY_NAME),
+    USER_DEFINED_FUNCTIONS(UserDefinedFunctionsFormat.IS_ZIP_ENTRY_NAME),
     WAREHOUSES(WarehousesFormat.AU_ZIP_ENTRY_NAME);
 
     private final String value;
@@ -63,6 +65,8 @@ private enum Format {
 
   private final ImmutableList<AssessmentQuery> assessmentQueries =
       ImmutableList.of(
+          AssessmentQuery.createUserDefinedFunctionsSelect(
+              Format.USER_DEFINED_FUNCTIONS, UPPER_UNDERSCORE),
           AssessmentQuery.createMetricsSelect(Format.TABLE_STORAGE_METRICS, UPPER_UNDERSCORE),
           AssessmentQuery.createShow("WAREHOUSES", Format.WAREHOUSES, LOWER_UNDERSCORE),
           SHOW_EXTERNAL_TABLES,
@@ -142,6 +146,17 @@ static AssessmentQuery createMetricsSelect(Format zipFormat, CaseFormat caseForm
       return new AssessmentQuery(true, formatString, zipFormat.value, caseFormat);
     }
 
+    static AssessmentQuery createUserDefinedFunctionsSelect(
+        Format zipFormat, CaseFormat caseFormat) {
+      String formatString =
+          "SELECT FUNCTION_CATALOG, FUNCTION_SCHEMA, FUNCTION_NAME, FUNCTION_LANGUAGE, ARGUMENT_SIGNATURE, "
+              + "FUNCTION_OWNER, COMMENT, VOLATILITY, RUNTIME_VERSION, LAST_ALTERED, "
+              + "PACKAGES, IMPORTS, IS_AGGREGATE, IS_DATA_METRIC, IS_MEMOIZABLE "
+              + "FROM SNOWFLAKE.ACCOUNT_USAGE.FUNCTIONS "
+              + "WHERE FUNCTION_SCHEMA != 'INFORMATION_SCHEMA' ";
+      return new AssessmentQuery(false, formatString, zipFormat.value, caseFormat);
+    }
+
     static AssessmentQuery createShow(String view, Format zipFormat, CaseFormat caseFormat) {
       String queryString = String.format("SHOW %s", view);
       return new AssessmentQuery(false, queryString, zipFormat.value, caseFormat);

dumper/lib-dumper-spi/src/main/java/com/google/edwmigration/dumper/plugin/lib/dumper/spi/SnowflakeMetadataDumpFormat.java

@@ -107,6 +107,29 @@ enum Header {
     }
   }
 
+  interface UserDefinedFunctionsFormat {
+
+    String IS_ZIP_ENTRY_NAME = "user_defined_functions.csv";
+
+    enum Header {
+      FUNCTION_CATALOG,
+      FUNCTION_SCHEMA,
+      FUNCTION_NAME,
+      FUNCTION_LANGUAGE,
+      ARGUMENT_SIGNATURE,
+      FUNCTION_OWNER,
+      COMMENT,
+      VOLATILITY,
+      RUNTIME_VERSION,
+      LAST_ALTERED,
+      PACKAGES,
+      IMPORTS,
+      IS_AGGREGATE,
+      IS_DATA_METRIC,
+      IS_MEMOIZABLE
+    }
+  }
+
   interface FunctionInfoFormat {
     String AU_ZIP_ENTRY_NAME = "function_info.csv";
   }