Skip to content

Commit d275921

Browse files
committed
Use more descriptive names
1 parent 06fbdb2 commit d275921

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/hadoop/oozie/AbstractOozieJobsTask.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,13 @@ private static Object[] toCSVRecord(Object job, ImmutableList<String> header) th
162162
for (int i = 0; i < header.size(); i++) {
163163
Object property = jobObjectWrapper.getPropertyValue(header.get(i));
164164
if (property != null) {
165-
record[i] = toRecord(property);
165+
record[i] = toRecordProperty(property);
166166
}
167167
}
168168
return record;
169169
}
170170

171-
static Object toRecord(Object property) throws JsonProcessingException {
171+
static Object toRecordProperty(Object property) throws JsonProcessingException {
172172
if (property instanceof Date) {
173173
// avoid date formats complexity and use milliseconds
174174
return ((Date) property).getTime();

dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/connector/hadoop/oozie/AbstractOozieJobsTaskTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,29 +31,29 @@ public class AbstractOozieJobsTaskTest {
3131
static final SimpleDateFormat dateFormat = new SimpleDateFormat("yyyy-MM-dd");
3232

3333
@Test
34-
public void toRecord_dateArgument_convertsToLong() throws Exception {
34+
public void toRecordProperty_dateArgument_convertsToLong() throws Exception {
3535
Date christmas = dateFormat.parse("2025-12-25");
3636

37-
Object result = AbstractOozieJobsTask.toRecord(christmas);
37+
Object result = AbstractOozieJobsTask.toRecordProperty(christmas);
3838

3939
assertEquals(Long.class, result.getClass());
4040
assertEquals("2025-12-25", convertDate(result));
4141
}
4242

4343
@Test
44-
public void toRecord_listArgument_success() throws Exception {
44+
public void toRecordProperty_listArgument_success() throws Exception {
4545
ImmutableList<String> list = ImmutableList.of("abcde", "fghi");
4646

47-
Object result = AbstractOozieJobsTask.toRecord(list);
47+
Object result = AbstractOozieJobsTask.toRecordProperty(list);
4848

4949
assertEquals("[\"abcde\",\"fghi\"]", result);
5050
}
5151

5252
@Test
53-
public void toRecord_otherArgument_nothingChanges() throws Exception {
53+
public void toRecordProperty_otherArgument_nothingChanges() throws Exception {
5454
Object value = new Object();
5555

56-
Object result = AbstractOozieJobsTask.toRecord(value);
56+
Object result = AbstractOozieJobsTask.toRecordProperty(value);
5757

5858
assertEquals(value, result);
5959
}

0 commit comments

Comments
 (0)