Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default error action for malformed input and unmappable characters #7218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobbi
Copy link

@tobbi tobbi commented May 14, 2024

I have to preface this by saying that I'm quite new to this codebase. However, I looked through the issues list and fixing the linked issue seemed trivial enough so I gave it a shot.

Maybe, if things work out and I learn quickly, I might try tackling larger issues.

If anything else is needed, please go ahead and tell me.

Fixes #6944

@chaoren
Copy link
Member

chaoren commented May 15, 2024

Sorry, we haven't gotten around to making a decision on #6944 yet.

Per https://github.com/google/guava/wiki/HowToContribute#code-contributions:

  1. Discuss the feature request until it is marked Accepted.

should happen before

  1. Implement the change.

@tobbi
Copy link
Author

tobbi commented May 15, 2024

No problem. I guess I'll just wait, unless you decide to implement things yourself. Nonetheless, I'm interested in contributing. Are there any "good first issue"-type issues I could try?

@chaoren
Copy link
Member

chaoren commented May 15, 2024

Filing and/or commenting on issues is probably the best way to contribute. We'd rather have everything hashed out completely before having anyone start working on an implementation.

@tobbi
Copy link
Author

tobbi commented May 15, 2024

How do you mark feature requests as accepted? Does that happen on Github? At first glance I couldn't find a suitable label.

@chaoren
Copy link
Member

chaoren commented May 15, 2024

Yeah, I also expected there to be a status=accepted label given the contribution guidelines. I'll check if we can get that label added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider reporting errors during encoding in ReaderInputStream
2 participants