Shim: Add support for cgroups v2 stats #11472
Labels
type: bug
Something isn't working
Comments
Champ-Goblem
added a commit
to Champ-Goblem/gvisor
that referenced
this issue
Feb 13, 2025
…inerd metrics in the shim, v2 metrics are only used when runsc is run with --system-cgroup=true.\nContainerd requires v2 metrics when the host is run with CGroupsV2.\nThis issue was noticed when attempting to gather metrics on AL2023 which defaults to CGroupsV2.\nFixes: google#11472 Signed-off-by: Champ-Goblem <[email protected]>
Champ-Goblem
added a commit
to Champ-Goblem/gvisor
that referenced
this issue
Feb 13, 2025
Add support for v2 containerd metrics in the shim, v2 metrics are only used when runsc is run with --system-cgroup=true. Containerd requires v2 metrics when the host is run with CGroupsV2. This issue was noticed when attempting to gather metrics on AL2023 which defaults to CGroupsV2. Fixes: google#11472 Signed-off-by: Champ-Goblem <[email protected]>
|
Testing this change on AWS AL2022 vs AL2023:
Commands used for testing: CPU: The difference between runC and gVisor might be a separate issue. |
|
cc @milantracy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, the shim supports CRI stats interface but only uses the v1 version of metrics. This causes issues with gathering containerd-based workload metrics on CGroup V2 systems, where containerd expects the shim to return the V2 metrics https://github.com/containerd/containerd/blob/main/core/metrics/cgroups/cgroups.go#L85-L88.
When the two versions are mismatched, containerd errors about failing to gather metrics for a container:
or
depending on the version of containerd used.
Steps to reproduce
No response
runsc version
docker version (if using docker)
uname
No response
kubectl (if using Kubernetes)
repo state (if built from source)
No response
runsc debug logs (if available)
The text was updated successfully, but these errors were encountered: