Re-enable old fee extensions in sandbox (#2939)

Now that we've passed the RST testing (or at least the EPP portion of
it) we are no longer bound by the restriction to only use the fee
extension version 1.0 on sandbox.

For now, in order to avoid changing prod behavior, this does not enable
advertisement of the fee extension version 1.0 in production. We can
change this at any point in the future.

Author: gbrodman

core/src/main/java/google/registry/model/eppcommon/EppXmlTransformer.java

@@ -23,7 +23,6 @@
 import google.registry.model.ImmutableObject;
 import google.registry.model.eppinput.EppInput;
 import google.registry.model.eppoutput.EppOutput;
-import google.registry.util.NonFinalForTesting;
 import google.registry.util.RegistryEnvironment;
 import google.registry.xml.ValidationMode;
 import google.registry.xml.XmlException;
@@ -61,35 +60,20 @@ public class EppXmlTransformer  {
   // XML schemas that should not be used in production (yet)
   private static final ImmutableSet<String> NON_PROD_SCHEMAS = ImmutableSet.of("fee-std-v1.xsd");
 
-  // XML schemas that should only be used in production (for backcompat)
-  private static final ImmutableSet<String> ONLY_PROD_SCHEMAS =
-      ImmutableSet.of("fee06.xsd", "fee11.xsd", "fee12.xsd");
-
-  // TODO(gbrodman): make this final when we can actually remove the old fee extensions and aren't
-  // relying on switching by environment
-  @NonFinalForTesting
-  private static XmlTransformer INPUT_TRANSFORMER =
+  private static final XmlTransformer INPUT_TRANSFORMER =
       new XmlTransformer(getSchemas(), EppInput.class);
 
-  // TODO(gbrodman): make this final when we can actually remove the old fee extensions and aren't
-  // relying on switching by environment
-  @NonFinalForTesting
-  private static XmlTransformer OUTPUT_TRANSFORMER =
+  private static final XmlTransformer OUTPUT_TRANSFORMER =
       new XmlTransformer(getSchemas(), EppOutput.class);
 
   @VisibleForTesting
   public static ImmutableList<String> getSchemas() {
-    ImmutableSet<String> schemasToSkip =
-        RegistryEnvironment.get().equals(RegistryEnvironment.PRODUCTION)
-            ? NON_PROD_SCHEMAS
-            : ONLY_PROD_SCHEMAS;
-    return ALL_SCHEMAS.stream().filter(s -> !schemasToSkip.contains(s)).collect(toImmutableList());
-  }
-
-  @VisibleForTesting
-  public static void reloadTransformers() {
-    INPUT_TRANSFORMER = new XmlTransformer(getSchemas(), EppInput.class);
-    OUTPUT_TRANSFORMER = new XmlTransformer(getSchemas(), EppOutput.class);
+    if (RegistryEnvironment.get().equals(RegistryEnvironment.PRODUCTION)) {
+      return ALL_SCHEMAS.stream()
+          .filter(s -> !NON_PROD_SCHEMAS.contains(s))
+          .collect(toImmutableList());
+    }
+    return ALL_SCHEMAS;
   }
 
   public static void validateOutput(String xml) throws XmlException {

core/src/main/java/google/registry/model/eppcommon/ProtocolDefinition.java

@@ -54,7 +54,6 @@ public class ProtocolDefinition {
   /** Enum representing which environments should have which service extensions enabled. */
   private enum ServiceExtensionVisibility {
     ALL,
-    ONLY_IN_PRODUCTION,
     ONLY_IN_NON_PRODUCTION,
     NONE
   }
@@ -67,15 +66,15 @@ public enum ServiceExtension {
     FEE_0_6(
         FeeCheckCommandExtensionV06.class,
         FeeCheckResponseExtensionV06.class,
-        ServiceExtensionVisibility.ONLY_IN_PRODUCTION),
+        ServiceExtensionVisibility.ALL),
     FEE_0_11(
         FeeCheckCommandExtensionV11.class,
         FeeCheckResponseExtensionV11.class,
-        ServiceExtensionVisibility.ONLY_IN_PRODUCTION),
+        ServiceExtensionVisibility.ALL),
     FEE_0_12(
         FeeCheckCommandExtensionV12.class,
         FeeCheckResponseExtensionV12.class,
-        ServiceExtensionVisibility.ONLY_IN_PRODUCTION),
+        ServiceExtensionVisibility.ALL),
     FEE_1_00(
         FeeCheckCommandExtensionStdV1.class,
         FeeCheckResponseExtensionStdV1.class,
@@ -117,7 +116,6 @@ public static String getCommandExtensionUri(Class<? extends CommandExtension> cl
     public boolean isVisible() {
       return switch (visibility) {
         case ALL -> true;
-        case ONLY_IN_PRODUCTION -> RegistryEnvironment.get().equals(RegistryEnvironment.PRODUCTION);
         case ONLY_IN_NON_PRODUCTION ->
             !RegistryEnvironment.get().equals(RegistryEnvironment.PRODUCTION);
         case NONE -> false;