Skip to content

Conversation

@wenta0g
Copy link
Collaborator

@wenta0g wenta0g commented Jan 16, 2026

This PR fix the problem when issuing /gcbrun command with additional args -- additional_args. The additional_args may flow to web.py or run_all_experiment.py, causing web.py to fail when the args are exclusively to run_all_experiment.py

@wenta0g
Copy link
Collaborator Author

wenta0g commented Jan 16, 2026

/gcbrun exp -n wentao -m vertex_ai_gemini-2-5-pro-chat -b quick-test -ns 1 -- -csv -ag

@github-actions
Copy link

@wenta0g
Copy link
Collaborator Author

wenta0g commented Jan 20, 2026

/gcbrun exp -n wentao -m vertex_ai_gemini-2-5-pro-chat -b quick-test -ns 1 -- -csv -ag

@github-actions
Copy link

@wenta0g
Copy link
Collaborator Author

wenta0g commented Jan 20, 2026

Hi @DonggeLiu, I checked the additional arg parsing conflict we discussed before. I am proposing to add an additional argument splitter in docker_run.py to parse and extract flags exclusive to web.py (e.g., -csv, -gs). Only the rest of the additional args will be piped to run_all_experiment.py

My example run added two additional args: -- -csv -ag, both are parsed as expected.
-csv to export a csv file in results dir, which is a web.py option, exported here: https://storage.cloud.google.com/oss-fuzz-gcb-experiment-run-logs/Result-reports/ofg-pr/2026-01-19-1217-wentao-quick-test/crashes.csv;
and -ag activated agent mode, evident from any of the logs: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2026-01-19-1217-wentao-quick-test/sample/output-astc-encoder-_z10encode_ise12quant_methodjpkhphj/01.html

@wenta0g wenta0g marked this pull request as ready for review January 20, 2026 08:36
@wenta0g wenta0g requested a review from DonggeLiu January 20, 2026 08:36
@DonggeLiu
Copy link
Collaborator

Thanks @wenta0g!
It appears report generation failed again due to a bug in parse_training_data.py.
Would you mind commenting out these lines to unblock report generation at your convenience?

Feel free to do this in this PR or a new PR. I don' think the bug relates to this PR.

@wenta0g
Copy link
Collaborator Author

wenta0g commented Jan 21, 2026

Thanks, Dongge! I removed the quoted lines under this PR.

@DonggeLiu
Copy link
Collaborator

Thanks, Dongge! I removed the quoted lines under this PR.

Thanks! Shall we run another experiment at your convenience to test report generation?

@wenta0g
Copy link
Collaborator Author

wenta0g commented Jan 21, 2026

/gcbrun exp -n wentao -m vertex_ai_gemini-2-5-pro-chat -b quick-test -ns 1 -- -csv -ag

@github-actions
Copy link

@wenta0g
Copy link
Collaborator Author

wenta0g commented Jan 21, 2026

Hi @DonggeLiu, the public-facing report looks good to me. Let me know if there's any GKE issue that I'm not aware of.

@DonggeLiu
Copy link
Collaborator

Hi @DonggeLiu, the public-facing report looks good to me. Let me know if there's any GKE issue that I'm not aware of.

Nope, this should be good to merge.

BTW, this is the correct report URL: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2026-01-20-1217-wentao-quick-test/index.html

There is a known date mismatch issue (2026-01-20 vs 2026-01-21-1217) in some github action comments due to timezone.

You can find the correct URLs at:
https://github.com/google/oss-fuzz-gen/pull/1217/checks?check_run_id=60971202064

@DonggeLiu DonggeLiu merged commit ee97fdd into google:main Jan 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants