Remaining Container Scanning Issues for v2 Official Release #1528
Assignees
Labels
container-scanning-v2
blockers for container scanning V2 release
Comments
hogo6002
added
the
container-scanning-v2
10 tasks
|
And issues listed here: #1274 (comment) |
3 tasks
another-rex
added a commit
that referenced
this issue
Feb 5, 2025
Made a series of changes to resolve the issues identified in #1528 Hosted an example here: https://another-rex.github.io/TestPages/Vulnerability%20Scan%20Report.html To make it easier to see the changes, when reviewing, use this link: https://github.com/google/osv-scanner/pull/1561/files/bd8d5211e77612b1a0a68a4b00db1d40535fe400..8223593ef84cda34da84a57aecd12d3258ea1463 which select the diffs **Excluding** the first commit (use shift to select multiple commits). That moves the files around which breaks all of git's diffing. No change other than moving the files and reindenting is done in that first commit. HTML: - Move to actual .js and .css file rather than .html files. - Alias and groupid tooltips now put each ID on a new line. - Can now click on the entire filter box to change it, not just on the text part. CSS: - Remove max-height in the inner tables, this was making it impossible to have tooltips that escape the container (at least I haven't figured out how to have both). - Tooltip box sizing is now dynamic with max-width - Tooltips now display upwards instead of downwards - Highlight source path better - Minor refactor to how the search box is laid out - Remove unused css lines. - Make iframe bg color black instead of white to avoid flash banging people. JS: - Remove all style edits in javascript, state changes are made with classes now. (TIL `classList.toggle()` function) - Basic linter pass (e.g. use const on variables, define all variables...etc) - Run showAllVulns() function at page load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracker used to track container scanning issues specifically for the official v2 release.
Functionality:
Testing:
Performance:
Output:
--serve to automatically find a unused port around 8000 rather than immediately failing.(don't need it, as we plan to allow users to specify the port)Any issues mentioned in discussion #1521
The text was updated successfully, but these errors were encountered: