feat(otuput): add license scanning results into the new Result struct #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1611 +/- ##
==========================================
+ Coverage 69.33% 69.36% +0.03%
==========================================
Files 200 200
Lines 19042 19082 +40
==========================================
+ Hits 13202 13237 +35
- Misses 5134 5138 +4
- Partials 706 707 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
LicenseSummarystruct to store the count of each license.LicensesandLicenseViolationsfieldscalculateLicenseSummary, mostly copying code from table.go/licenseSummaryTableBuilder().Licensesresutls to all formatsTable output - container scanning:
with
experimental-licenses-summaryflag:with
experimental-licensesflag:Table output - project scanning (unchanged)
Vertical output:
with
experimental-licenses-summaryflag:with
experimental-licensesflag (adds it back, same as before):HTML output:
with
experimental-licenses-summaryflag:with
experimental-licensesflag:One issue here is that the HTML filter currently hides packages that have no vulnerabilities. So packages without vulnerabilities but with license violations will also be hidden.
Resolves #1576