Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The importer does not honour ignore_patterns for REST sources #2436

Open
andrewpollock opened this issue Aug 1, 2024 · 1 comment
Open
Labels
backlog Important but currently unprioritized bug Something isn't working

Comments

@andrewpollock
Copy link
Contributor

andrewpollock commented Aug 1, 2024

Describe the bug
#2434 (comment) identified that

def _process_updates_rest(self, source_repo: osv.SourceRepository):
does not call
def _is_vulnerability_file(source_repo, file_path):
and therefore the SourceRepo ignore_patterns is not honoured

Expected behaviour
ignore_patterns behaves consistently for all supported source types

@andrewpollock andrewpollock added the bug Something isn't working label Aug 1, 2024
Copy link

This issue has not had any activity for 60 days and will be automatically closed in two weeks

See https://github.com/google/osv.dev/blob/master/CONTRIBUTING.md for how to contribute a PR if you're interested in helping out.

@github-actions github-actions bot added the stale The issue or PR is stale and pending automated closure label Oct 11, 2024
@oliverchang oliverchang added backlog Important but currently unprioritized and removed stale The issue or PR is stale and pending automated closure labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Important but currently unprioritized bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@oliverchang @andrewpollock and others