Skip to content

ui: Pressing escape or clicking outside a popup (on the timeline) should not cancel the selection #3629

@stevegolton

Description

@stevegolton

Clicking outside a popup or pressing escape are both ways to close that popup, however they also have additional side effects as the event is propagated through the other elements that are clicked on / interact with hotkeys. The most grievous issue is this can cancel the selection on the timeline page.

More succinctly:

  • Clicking outside a popup should have no other effect other than closing the popup.
  • Pressing escape when a popup is open should have no other effect other than closing the popup.

See the attached video:

02fcb532-4bc2-421b-add1-1af6689c3440.webm

Metadata

Metadata

Assignees

Labels

fixituiIssues relating to the Perfetto UI

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions