Skip to content

Commit c920d8f

Browse files
committed
Make better test case names
1 parent 960c16f commit c920d8f

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

src/s2/s2region_term_indexer_test.cc

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
#include <gtest/gtest.h>
2727

2828
#include "absl/container/flat_hash_map.h"
29+
#include "absl/strings/str_cat.h"
2930

3031
#include "s2/base/commandlineflags.h"
3132
#include "s2/base/logging.h"
@@ -45,7 +46,10 @@ S2_DEFINE_int32(iters, 400, "number of iterations for testing");
4546

4647
namespace {
4748

48-
enum DataType { POINT, CAP };
49+
enum DataType {
50+
POINT = 0,
51+
CAP = 1,
52+
};
4953

5054
void TestRandomCaps(const S2RegionTermIndexer::Options& options,
5155
DataType index_type, DataType query_type) {
@@ -148,7 +152,13 @@ INSTANTIATE_TEST_CASE_P(
148152
S2RegionTermIndexerTests, S2RegionTermIndexerTest,
149153
testing::Combine(testing::Values(DataType::POINT, DataType::CAP),
150154
testing::Values(DataType::POINT, DataType::CAP),
151-
testing::Bool(), testing::Bool(), testing::Bool()));
155+
testing::Bool(), testing::Bool(), testing::Bool()),
156+
[](const testing::TestParamInfo<TestCase>& info) {
157+
return absl::StrCat(
158+
"Index", std::get<0>(info.param), "Query", std::get<1>(info.param),
159+
"SpaceOpt", std::get<2>(info.param), "IndexOpt",
160+
std::get<3>(info.param), "QueryOpt", std::get<4>(info.param));
161+
});
152162

153163
TEST_P(S2RegionTermIndexerTest, DefaultParametersValues) {
154164
TestRandomCaps(options, index_type, query_type);

0 commit comments

Comments
 (0)