Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure with C++14 #401

Open
jmr opened this issue Dec 4, 2024 · 0 comments
Open

Compilation failure with C++14 #401

jmr opened this issue Dec 4, 2024 · 0 comments

Comments

@jmr
Copy link
Member

jmr commented Dec 4, 2024

As reported in #400 (comment) there is a compilation failure with C++14 due to if constexpr.

/s2geometry/src/s2/util/math/vector.h:103:8: warning: ‘if constexpr’ only available with ‘-std=c++17’ or ‘-std=gnu++17’ [-Wc++17-extensions]
  103 |     if constexpr (I >= 0 && I < SIZE) return AsD().Data()[I];

We can either rewrite to avoid if constexpr or drop C++14 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant