-
Notifications
You must be signed in to change notification settings - Fork 322
Open
Labels
Next UpIssues to prioritize for definitionIssues to prioritize for definitionP0High priorityHigh priorityTeam SIssues for Squad 1Issues for Squad 1Type: InfrastructureEngineering infrastructure & toolingEngineering infrastructure & tooling
Description
Bug Description
The Google Charts VRTs have been very unstable, suffering from many timeouts/bugs lately, resulting in a lot of "false negative" VRT test failures.
The suite is time-consuming even to check, but also to re-run, so we should disable these tests until a fix is found (see: #11619).
The test failures usually look something like this:


Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- All Google Charts VRTs (largely in "All Traffic Widget") should be disabled temporarily, via a TODO comment with a note referencing them being restored in Fix instability (or remove) previously-disabled Google Charts VRTs #11619.
Implementation Brief
- Comment out the following VRTs, adding TODOs explaining they should be restored:
- In
assets/js/modules/analytics-4/components/dashboard/DashboardAllTrafficWidgetGA4/indexEntityDashboard.stories.js
-
EntityDashboardLoaded.scenario
-
EntityDashboardOneRowOfData.scenario
-
NoDataInComparisonDateRange.scenario
-
- In
- Merge Disable flakey Google Charts VRT tests. #11621 (issue can be moved directly to Code Review after IB is approved).
Test Coverage
- Issue applies to visual tests.
QA Brief
- No QA is needed as this is only related to tests. Can be moved directly to Approval.
Changelog entry
- N/A
Metadata
Metadata
Assignees
Labels
Next UpIssues to prioritize for definitionIssues to prioritize for definitionP0High priorityHigh priorityTeam SIssues for Squad 1Issues for Squad 1Type: InfrastructureEngineering infrastructure & toolingEngineering infrastructure & tooling