Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ZopfliPNG static library build rule #179

Open
OpenA opened this issue Feb 9, 2021 · 0 comments
Open

Incorrect ZopfliPNG static library build rule #179

OpenA opened this issue Feb 9, 2021 · 0 comments

Comments

@OpenA
Copy link

OpenA commented Feb 9, 2021

It's not include zopfli object files (and not working if i just separatly linking libzopflipng.a + libzopfli.a in my project)

diff --git a/Makefile b/Makefile
index 5407de8..36a80ae 100644
--- a/Makefile
+++ b/Makefile
@@ -57,7 +57,7 @@ libzopflipng: $(ZOPFLILIB_OBJ) $(LODEPNG_OBJ) $(ZOPFLIPNGLIB_OBJ)
 	$(CXX) $^ $(CFLAGS) --shared -Wl,-soname,libzopflipng.so.1 -o libzopflipng.so.1.0.3 $(LDFLAGS)
 
 # ZopfliPNG static library
-libzopflipng.a: $(LODEPNG_OBJ) $(ZOPFLIPNGLIB_OBJ)
+libzopflipng.a: $(LODEPNG_OBJ) $(ZOPFLILIB_OBJ) $(ZOPFLIPNGLIB_OBJ)
 	ar rcs $@ $^
 
 # Remove all libraries and binaries

but in shared library it have and all working

# ZopfliPNG shared library
libzopflipng: $(ZOPFLILIB_OBJ) $(LODEPNG_OBJ) $(ZOPFLIPNGLIB_OBJ)
	$(CXX) $^ $(CFLAGS) --shared -Wl,-soname,libzopflipng.so.1 -o libzopflipng.so.1.0.3 $(LDFLAGS)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant