Skip to content

Commit c9f26a5

Browse files
committed
Fix import statements in planning examples
Change-Id: I2c83e7de9738293c1127f60c40d118d27f4ad740
1 parent 0c84c9a commit c9f26a5

File tree

4 files changed

+22
-29
lines changed

4 files changed

+22
-29
lines changed

examples/planning/generate_forecast_metrics.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@
2424

2525
from google.ads.googleads.client import GoogleAdsClient
2626
from google.ads.googleads.errors import GoogleAdsException
27-
from google.ads.googleads.v20.enums.types.keyword_plan_network import (
28-
KeywordPlanNetworkEnum,
29-
)
30-
from google.ads.googleads.v20.enums.types.keyword_match_type import (
31-
KeywordMatchTypeEnum,
27+
from google.ads.googleads.v20.common.types.criteria import (
28+
KeywordInfo,
3229
)
3330
from google.ads.googleads.v20.services.services.google_ads_service.client import (
3431
GoogleAdsServiceClient,
@@ -41,7 +38,6 @@
4138
CriterionBidModifier,
4239
ForecastAdGroup,
4340
BiddableKeyword,
44-
KeywordInfo,
4541
GenerateKeywordForecastMetricsRequest,
4642
GenerateKeywordForecastMetricsResponse,
4743
)
@@ -165,8 +161,8 @@ def generate_forecast_metrics(
165161
customer_id: a client customer ID.
166162
campaign_to_forecast: a CampaignToForecast to generate metrics for.
167163
"""
168-
keyword_plan_idea_service: KeywordPlanIdeaServiceClient = client.get_service(
169-
"KeywordPlanIdeaService"
164+
keyword_plan_idea_service: KeywordPlanIdeaServiceClient = (
165+
client.get_service("KeywordPlanIdeaService")
170166
)
171167
request: GenerateKeywordForecastMetricsRequest = client.get_type(
172168
"GenerateKeywordForecastMetricsRequest"

examples/planning/generate_historical_metrics.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,15 @@
1818
https://developers.google.com/google-ads/api/docs/keyword-planning/generate-historical-metrics
1919
"""
2020

21+
from typing import Iterable
2122
import argparse
2223
import sys
2324

2425
from google.ads.googleads.client import GoogleAdsClient
2526
from google.ads.googleads.errors import GoogleAdsException
26-
from google.ads.googleads.v20.enums.types.keyword_plan_network import (
27-
KeywordPlanNetworkEnum,
27+
from google.ads.googleads.v20.common.types.keyword_plan_common import (
28+
KeywordPlanHistoricalMetrics,
29+
MonthlySearchVolume,
2830
)
2931
from google.ads.googleads.v20.services.services.google_ads_service.client import (
3032
GoogleAdsServiceClient,
@@ -35,8 +37,7 @@
3537
from google.ads.googleads.v20.services.types.keyword_plan_idea_service import (
3638
GenerateKeywordHistoricalMetricsRequest,
3739
GenerateKeywordHistoricalMetricsResponse,
38-
KeywordMetrics,
39-
MonthlySearchVolume,
40+
GenerateKeywordHistoricalMetricsResult,
4041
)
4142

4243

@@ -61,8 +62,8 @@ def generate_historical_metrics(client: GoogleAdsClient, customer_id: str):
6162
googleads_service: GoogleAdsServiceClient = client.get_service(
6263
"GoogleAdsService"
6364
)
64-
keyword_plan_idea_service: KeywordPlanIdeaServiceClient = client.get_service(
65-
"KeywordPlanIdeaService"
65+
keyword_plan_idea_service: KeywordPlanIdeaServiceClient = (
66+
client.get_service("KeywordPlanIdeaService")
6667
)
6768
request: GenerateKeywordHistoricalMetricsRequest = client.get_type(
6869
"GenerateKeywordHistoricalMetricsRequest"
@@ -87,9 +88,9 @@ def generate_historical_metrics(client: GoogleAdsClient, customer_id: str):
8788
)
8889
)
8990

90-
result: KeywordMetrics
91-
for result in response.results:
92-
metrics: KeywordMetrics = result.keyword_metrics
91+
results: Iterable[GenerateKeywordHistoricalMetricsResult] = response.results
92+
for result in results:
93+
metrics: KeywordPlanHistoricalMetrics = result.keyword_metrics
9394
# These metrics include those for both the search query and any variants
9495
# included in the response.
9596
print(
@@ -126,8 +127,8 @@ def generate_historical_metrics(client: GoogleAdsClient, customer_id: str):
126127

127128
# Approximate number of searches on this query for the past twelve
128129
# months.
129-
month: MonthlySearchVolume
130-
for month in metrics.monthly_search_volumes:
130+
months: Iterable[MonthlySearchVolume] = metrics.monthly_search_volumes
131+
for month in months:
131132
print(
132133
f"\tApproximately {month.monthly_searches} searches in "
133134
f"{month.month.name}, {month.year}"

examples/planning/generate_keyword_ideas.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
from google.ads.googleads.v20.services.types.keyword_plan_idea_service import (
3838
GenerateKeywordIdeasRequest,
3939
GenerateKeywordIdeaResult,
40-
UrlSeed,
41-
KeywordSeed,
42-
KeywordAndUrlSeed,
4340
)
4441

4542
# Location IDs are listed here:
@@ -62,8 +59,8 @@ def main(
6259
keyword_texts: list[str],
6360
page_url: str,
6461
):
65-
keyword_plan_idea_service: KeywordPlanIdeaServiceClient = client.get_service(
66-
"KeywordPlanIdeaService"
62+
keyword_plan_idea_service: KeywordPlanIdeaServiceClient = (
63+
client.get_service("KeywordPlanIdeaService")
6764
)
6865
keyword_competition_level_enum: KeywordPlanCompetitionLevelEnum = (
6966
client.enums.KeywordPlanCompetitionLevelEnum

examples/planning/get_ad_group_criterion_cpc_bid_simulations.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
To get ad groups, run get_ad_groups.py.
1818
"""
1919

20-
20+
from typing import Iterable
2121
import argparse
2222
import sys
2323

24-
from collections.abc import Iterator
2524
from google.ads.googleads.client import GoogleAdsClient
2625
from google.ads.googleads.errors import GoogleAdsException
2726
from google.ads.googleads.v20.resources.types.ad_group_criterion_simulation import (
@@ -58,9 +57,9 @@ def main(client: GoogleAdsClient, customer_id: str, ad_group_id: str):
5857
AND ad_group_criterion_simulation.ad_group_id = {ad_group_id}"""
5958

6059
# Issues a search request using streaming.
61-
stream: Iterator[
62-
SearchGoogleAdsStreamResponse
63-
] = googleads_service.search_stream(customer_id=customer_id, query=query)
60+
stream: Iterable[SearchGoogleAdsStreamResponse] = (
61+
googleads_service.search_stream(customer_id=customer_id, query=query)
62+
)
6463

6564
# Iterates over all rows in all messages and prints the requested field
6665
# values for the ad group criterion CPC bid simulation in each row.

0 commit comments

Comments
 (0)