Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support providing binary file contents in base64 encoding #506

Open
rohanku opened this issue Jan 23, 2025 · 0 comments · May be fixed by #507
Open

Support providing binary file contents in base64 encoding #506

rohanku opened this issue Jan 23, 2025 · 0 comments · May be fixed by #507
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rohanku
Copy link

rohanku commented Jan 23, 2025

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
I am using release-please and need to overwrite binary files in my release flow. release-please uses code-suggester to create PRs.
Describe the solution you'd like
Simply add a field to FileData to declare whether the content string provided is in utf-8 or base64 encoding. I already have code for this (~ 20 lines of code) and can make a PR.
Describe alternatives you've considered
It is a fairly simple fix, not sure if there are any other ways to do it.
Additional context
N/A

@rohanku rohanku added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 23, 2025
@rohanku rohanku linked a pull request Jan 23, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant