Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Use Headers for Headers #1659

Open
danielbankhead opened this issue Oct 9, 2024 · 0 comments
Open

refactor!: Use Headers for Headers #1659

danielbankhead opened this issue Oct 9, 2024 · 0 comments
Assignees
@danielbankhead
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@danielbankhead
Copy link
Contributor

Once the following lands upstream update this library for support:

gapic-generator-typescript/templates/cjs/typescript_gapic/_util.njk

Line 254 in 439d5a5

{%- macro buildHeaderRequestParam(method) -%}

@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 9, 2024
@danielbankhead danielbankhead self-assigned this Oct 9, 2024
@danielbankhead danielbankhead added semver: major Hint for users that this is an API breaking change. next major: breaking change this is a change that we should wait to bundle into the next major version labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielbankhead danielbankhead

Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p2 Moderately-important priority. Fix may not be included in next release. semver: major Hint for users that this is an API breaking change. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielbankhead