New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CI test to make sure the generated gapic metadata file is parseable #790

Open

alexander-fenster opened this issue Dec 2, 2020 · 0 comments

Labels

type: feature request

Contributor

alexander-fenster commented Dec 2, 2020

Take baselines/showcase/src/v1beta1/gapic_metadata.json.baseline, make sure it can be parsed by Python protobuf JSON loading code like this one:

from google.protobuf.json_format import Parse
import gapic_metadata_pb2

with open("baselines/showcase/src/v1beta1/gapic_metadata.json.baseline", "r") as f:
  metadata = Parse(f.read(), gapic_metadata_pb2.GapicMetadata())
  print(metadata)

alexander-fenster self-assigned this

alexander-fenster added the type: feature request label

alexander-fenster mentioned this issue

fix: proper JSON format for GAPIC metadata file #791

Merged

alexander-fenster removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment