Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added a sync toolbox client #131

Merged
merged 41 commits into from
Apr 3, 2025
Merged

feat: Added a sync toolbox client #131

merged 41 commits into from
Apr 3, 2025

Conversation

twishabansal
Copy link
Contributor

@twishabansal twishabansal commented Apr 3, 2025 •
edited by anubhav756
Loading

This PR introduces a ToolboxSyncClient which allows for synchronous loading and execution of tools.

Eg

from toolbox_core import ToolboxSyncClient

tool = ToolboxSyncClient.load_tool("my-tool")
result = tool(foo="bar")

@twishabansal twishabansal marked this pull request as ready for review April 3, 2025 12:30
@twishabansal twishabansal requested a review from a team as a code owner April 3, 2025 12:30
@twishabansal twishabansal changed the title feat: Add sync interface for toolbox client feat: Added a sync toolbox client Apr 3, 2025
anubhav756
anubhav756 requested changes Apr 3, 2025
View reviewed changes
kurtisvg
kurtisvg requested changes Apr 3, 2025
View reviewed changes
anubhav756
anubhav756 approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@anubhav756 anubhav756 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits and a thought.

@twishabansal twishabansal merged commit ed82832 into main Apr 3, 2025
14 checks passed
@twishabansal twishabansal deleted the twisha-sync-wrapper branch April 3, 2025 18:19
@release-please release-please bot mentioned this pull request Apr 3, 2025
Merged
@twishabansal twishabansal mentioned this pull request Apr 3, 2025
Merged
@release-please release-please bot mentioned this pull request Apr 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubhav756 anubhav756 anubhav756 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twishabansal @anubhav756 @kurtisvg